Repository navigation
fix(cliproxy): make Kamino model families exclusive - #3242
Conversation
|
Warning This organization's free trial has ended, so Indent couldn't continue this review. Manage billing to resume reviews on this repository.
All required CI checks passed on
Select any unchecked box below to run or rerun that agent. Full resultsIndent Review Agent
|
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This PR makes Kamino model families exclusive across credentials in cliproxy. A credential with model_family set excludes all other families and remains eligible for its own. Credentials without model_family now receive exclusions for every family claimed by other credentials. Operator-authored exclusions are preserved.
home-manager/services/cliproxyapi/README.md— docs updated to describe exclusive family behaviorhome-manager/services/cliproxyapi/scripts/start.sh— addedmodel_family_exclusion()helper;apply_model_policies()now collects claimed families, validates them, applies per-family exclusions to assigned credentials (excluding other families only) and all-family exclusions to unassigned credentialsspec/cliproxyapi_spec.sh— test updated to cover two Haiku-assigned credentials + one unassigned credential
free | 𝕏

Changes
model_familyeligible for that family.Testing
shellspec spec/cliproxyapi_spec.sh spec/kamino_fleet_spec.sh(99 examples, 0 failures)Follow-up to #3241.
Summary by cubic
Makes Kamino model families exclusive across credentials in
cliproxyso a model family claimed by one credential is excluded from every other credential.model_familyset still excludes the other families and remains eligible for its own family.model_familynow receive exclusions for every family claimed by other credentials.Written for commit 8a03e3d. Summary will update on new commits.