Skip to content

fix(cliproxy): make Kamino model families exclusive - #3242

Merged
shunkakinoki merged 1 commit into
mainfrom
fix/kamino-exclusive-model-families
Oct 29, 2026
Merged

shunkakinoki merged 1 commit into
mainfrom
fix/kamino-exclusive-model-families

Conversation

@shunkakinoki

@shunkakinoki shunkakinoki commented Oct 29, 2026 •

Copy link
Copy Markdown
Owner

Changes

  • Make declared Kamino model families exclusive across credentials.
  • Keep credentials with the same model_family eligible for that family.
  • Exclude claimed families from unassigned credentials while preserving operator-authored exclusions.

Testing

  • shellspec spec/cliproxyapi_spec.sh spec/kamino_fleet_spec.sh (99 examples, 0 failures)
  • Nix evaluation/build of the Kamino package
  • Bash syntax, ShellCheck, nixfmt, and diff checks

Follow-up to #3241.


Summary by cubic

Makes Kamino model families exclusive across credentials in cliproxy so a model family claimed by one credential is excluded from every other credential.

  • A credential with model_family set still excludes the other families and remains eligible for its own family.
  • Credentials without a model_family now receive exclusions for every family claimed by other credentials.
  • Operator-authored exclusions in existing auth files are preserved alongside the new generated ones.
  • Unknown model families still fail the render.
  • Updates the spec to cover two credentials sharing a family and one unassigned credential.

Written for commit 8a03e3d. Summary will update on new commits.

View guided diff Turn on auto-fix

@indent

indent Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Warning

This organization's free trial has ended, so Indent couldn't continue this review. Manage billing to resume reviews on this repository.

CI Checks

All required CI checks passed on 8a03e3d.

Review agents

Select any unchecked box below to run or rerun that agent.

Pending (1)
  • Indent Review Agent · This agent has not run.
Full results

Indent Review Agent

  • Summary: This agent has not run.
  • Latest resultNo result — this agent has not run.

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@shunkakinoki
shunkakinoki marked this pull request as ready for review October 29, 2026 01:06
@shunkakinoki
shunkakinoki merged commit 6ee9269 into main Oct 29, 2026
10 checks passed
@shunkakinoki
shunkakinoki deleted the fix/kamino-exclusive-model-families branch October 29, 2026 01:06
@linear-code

linear-code Bot commented Oct 29, 2026

Copy link
Copy Markdown

SHUN-33669

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

This PR makes Kamino model families exclusive across credentials in cliproxy. A credential with model_family set excludes all other families and remains eligible for its own. Credentials without model_family now receive exclusions for every family claimed by other credentials. Operator-authored exclusions are preserved.

  • home-manager/services/cliproxyapi/README.md — docs updated to describe exclusive family behavior
  • home-manager/services/cliproxyapi/scripts/start.sh — added model_family_exclusion() helper; apply_model_policies() now collects claimed families, validates them, applies per-family exclusions to assigned credentials (excluding other families only) and all-family exclusions to unassigned credentials
  • spec/cliproxyapi_spec.sh — test updated to cover two Haiku-assigned credentials + one unassigned credential

Pullfrog  | View workflow run | Using free | 𝕏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant