Skip to content

feat: add on_merge progress callback to Trainer.train - #19

Closed
AmitMY wants to merge 1 commit into
mainfrom
feat/progress-callback
Closed

AmitMY wants to merge 1 commit into
mainfrom
feat/progress-callback

Conversation

@AmitMY

@AmitMY AmitMY commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add optional on_merge(step, total, token, nodes) callback to Trainer.train()
  • Called after each merge, enabling progress bars and logging
  • Backward compatible (default is None)

Stacked on #18.

Test plan

  • New callback test passes
  • ruff check . passes

🤖 Generated with Claude Code

@AmitMY
AmitMY force-pushed the feat/progress-callback branch 16 times, most recently from cd9fc6f to 0465d6d Compare April 8, 2026 17:26
- Optional on_merge(step, total, token, nodes) callback called after
  each merge, enabling progress bars and logging
- Backward compatible — callback is None by default

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@AmitMY
AmitMY force-pushed the feat/progress-callback branch from 0465d6d to c59d751 Compare April 8, 2026 17:27
@AmitMY

AmitMY commented Apr 8, 2026

Copy link
Copy Markdown
Contributor Author

Closing — replacing with a simpler progress=False flag on train() that uses tqdm.

@AmitMY AmitMY closed this Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant