fix(canonicalize): break sort ties by symbol key - #31
Merged
Merged
Conversation
Symbols stacked on a single anchor point - eyes S31400 and mouth S33e00 both at 482x482 - share a sort key, so their order fell through to the input index and the same sign written two ways canonicalized two ways. Appending the symbol key to the sort key makes the order total. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L5fpJJsMzwDHaHqysth3hi
The inline comment repeated the module docstring and README verbatim, and the two-symbol ordering test was subsumed by the permutation one. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L5fpJJsMzwDHaHqysth3hi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symbols stacked on one anchor point — eyes
S31400and mouthS33e00both at482x482— share a sort key, so their order fell through to the input index. The same sign written two ways canonicalized two ways:Appending the symbol key to
_sort_keymakes the order total. 49 of the 4,084 FSW signs in this repo's data contain such a stack.No behavior change otherwise: category order, overlap constraints, centering and box are untouched. Verified across those 4,084 signs — canonicalization still leaves every render pixel-identical and is still idempotent.
🤖 Generated with Claude Code
https://claude.ai/code/session_01L5fpJJsMzwDHaHqysth3hi