fix: remove parenthesis for historical backfill - #9814
Open
kevaundray wants to merge 3 commits into
Open
Conversation
Member
|
Good catch, the fix looks correct, as per the spec: https://github.com/ethereum/consensus-specs/blob/caeca85c6c4f60cfed3bf716afa571bfb0c72d59/specs/phase0/p2p-interface.md#compute_min_epochs_for_block_requests Just got to fix the formatting stuff as you mention |
chong-he
added
bug
churn_limit_quotient is a plain u64, so calling .as_u64() on it does not compile. Only min_validator_withdrawability_delay (an Epoch) needs the conversion.
kevaundray
marked this pull request as ready for review
August 18, 2026 00:31
chong-he
added
ready-for-review
|
Some required checks have failed. Could you please take a look @kevaundray? 🙏 |
mergify
Bot
added
waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(modified this in web UI, so probably doesn't compile)
Issue Addressed
This was computing (256 + 65536)/ 2 =32,896 epochs. I believe it should be 256 + 65536/2 = 33,024
Which issue # does this PR address?
Proposed Changes
Please list or describe the changes introduced by this PR.
Additional Info
Please provide any additional information. For example, future considerations
or information useful for reviewers.