Skip to content

TT-7658 warn if current bible is owned by another team - #553

Merged
gtryus merged 4 commits into
developfrom
TT-7658
Aug 28, 2026
Merged

TT-7658 warn if current bible is owned by another team#553
gtryus merged 4 commits into
developfrom
TT-7658

Conversation

@sarahentzel

@sarahentzel sarahentzel commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

if bibleid is edited and this team is not the owner, create a new bible

if bibleid is edited, create a new bible
@sarahentzel
sarahentzel requested a review from gtryus August 28, 2026 18:22
@sarahentzel
sarahentzel marked this pull request as ready for review August 28, 2026 18:26
@gtryus
gtryus requested a lite review from Copilot August 28, 2026 19:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds UI feedback and save-time logic in the renderer to better handle Bible ownership when editing Team publishing settings, so teams don’t accidentally overwrite another team’s Bible record when changing the Bible Id.

Changes:

  • Added a localized string and UI alert to inform users when the current Bible is owned by a different team.
  • Introduced resolveBibleForSave (with unit tests) to decide whether to reuse the current Bible or create a new one when saving.
  • Updated Team settings flow and Bible CRUD wiring to support “create new Bible when not owner” behavior.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/renderer/src/store/localization/reducers.tsx Adds bibleOwnerRights string to default English card strings.
src/renderer/src/store/localization/model.tsx Extends ICardsStrings with the new localization key.
src/renderer/src/store/localization/exported-strings-name.json Updates exported strings bundle reference.
src/renderer/src/crud/useBible.ts Adds UpdateAttribute usage and claimOwner parameter to relationship update path.
src/renderer/src/crud/resolveBibleForSave.ts New helper to select an existing/owned/new Bible record for persistence.
src/renderer/src/crud/resolveBibleForSave.test.ts Unit tests for resolveBibleForSave.
src/renderer/src/crud/index.ts Re-exports resolveBibleForSave.
src/renderer/src/components/Team/TeamDialog.tsx Uses resolveBibleForSave, adjusts Bible selection behavior, and passes owner name down to publishing UI.
src/renderer/src/components/PublishExpansion.tsx Adds ownerName prop and renders an info Alert showing the owning team name.
localization/TranscriberAdmin-en.xlf Adds cards.bibleOwnerRights unit.
localization/TranscriberAdmin-en-1.2.xliff Adds cards.bibleOwnerRights trans-unit with source context.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/renderer/src/components/Team/TeamDialog.tsx
@gtryus
gtryus merged commit 65c506d into develop Aug 28, 2026
2 checks passed
@gtryus
gtryus deleted the TT-7658 branch August 28, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants