Conversation
if bibleid is edited, create a new bible
Contributor
There was a problem hiding this comment.
Pull request overview
Adds UI feedback and save-time logic in the renderer to better handle Bible ownership when editing Team publishing settings, so teams don’t accidentally overwrite another team’s Bible record when changing the Bible Id.
Changes:
- Added a localized string and UI alert to inform users when the current Bible is owned by a different team.
- Introduced
resolveBibleForSave(with unit tests) to decide whether to reuse the current Bible or create a new one when saving. - Updated Team settings flow and Bible CRUD wiring to support “create new Bible when not owner” behavior.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/renderer/src/store/localization/reducers.tsx |
Adds bibleOwnerRights string to default English card strings. |
src/renderer/src/store/localization/model.tsx |
Extends ICardsStrings with the new localization key. |
src/renderer/src/store/localization/exported-strings-name.json |
Updates exported strings bundle reference. |
src/renderer/src/crud/useBible.ts |
Adds UpdateAttribute usage and claimOwner parameter to relationship update path. |
src/renderer/src/crud/resolveBibleForSave.ts |
New helper to select an existing/owned/new Bible record for persistence. |
src/renderer/src/crud/resolveBibleForSave.test.ts |
Unit tests for resolveBibleForSave. |
src/renderer/src/crud/index.ts |
Re-exports resolveBibleForSave. |
src/renderer/src/components/Team/TeamDialog.tsx |
Uses resolveBibleForSave, adjusts Bible selection behavior, and passes owner name down to publishing UI. |
src/renderer/src/components/PublishExpansion.tsx |
Adds ownerName prop and renders an info Alert showing the owning team name. |
localization/TranscriberAdmin-en.xlf |
Adds cards.bibleOwnerRights unit. |
localization/TranscriberAdmin-en-1.2.xliff |
Adds cards.bibleOwnerRights trans-unit with source context. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if bibleid is edited and this team is not the owner, create a new bible