TT 7348 desktop save

[gtryus]

• Introduced new tests for the writeFileLocal function to validate disk write operations, including successful writes and error handling for write failures.
• Enhanced nextUpload action to ensure it gracefully handles local disk write errors, dispatching appropriate failure actions and preventing cloud uploads when local saves fail.
• Updated the actions module to use async/await for improved readability and error handling in the nextUpload function.
• Mocked IPC methods for testing to simulate file operations without actual disk access.

[Copilot]

Pull request overview

This PR strengthens the desktop upload workflow by ensuring local media saves are correctly awaited and that local staging/write failures are handled without proceeding to cloud upload. It also adds focused tests around local disk write behavior via mocked Electron IPC.

Changes:

• Ensure writeFileLocal awaits the IPC write call so in-memory recordings aren’t treated as saved before the disk write completes.
• Improve offline/local-save flow in nextUpload to properly catch and report local write failures.
• Add Jest coverage for successful local writes and failure cases (including aborting cloud upload when local save fails).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/renderer/src/store/upload/actions.tsx	Awaits IPC disk writes and tightens async error handling around offline/local save behavior.
src/renderer/src/store/upload/actions.pendingRetry.test.ts	Adds tests validating disk-write success/failure and that cloud POST is skipped when local staging fails.

Suppressed comments (1)

src/renderer/src/store/upload/actions.pendingRetry.test.ts:504

• Avoid using a fixed setTimeout delay to wait for async work; it makes the test slower and can be flaky on slow CI. Since nextUpload schedules work via promises, flushing microtasks is enough to let the failure dispatch run.

    action(dispatch);
    await new Promise((resolve) => setTimeout(resolve, 20));

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.