Show picture dialog after selecting picture - #2600
Open
hahn-kev-bot wants to merge 3 commits into
Open
Conversation
Contributor
|
Warning Review limit reachedNext included review available in 33 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (14)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
the
💻 FW Lite
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
hahn-kev
changed the title
Adding a picture now opens the "Add Picture" dialog on an in-memory draft; the picture is only uploaded/created (and rendered in the field) once Submit is clicked. Update the tests that still assumed the old immediate-render flow to click Submit after uploading. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
registerLocalPreview mints an object URL per draft/replace and only revoked them at dispose(), so blob URLs piled up across a session of adding pictures. Add releaseLocalPreview(uri) (a no-op for real mediaUris) and free the draft's preview whenever it's superseded or discarded — on a new create, when switching to editing an existing picture, and on replace — bounding live previews to one at a time. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After taking a picture or selecting an image the dialog shows up:
AI summary
Summary
Add Picturemessage into viewer locale catalogs.Test plan
pnpm checkfromfrontend/viewer— 0 errors; existing ffmpeg-worker overwrite warning remains.pnpm test:storybook pictures-editorfromfrontend/viewer— 10 passed across Chromium and Firefox.