Skip to content

Encode build_options in base64 - #992

Merged
Enkidu93 merged 2 commits into
mainfrom
build_options_base64
Aug 28, 2026
Merged

Encode build_options in base64#992
Enkidu93 merged 2 commits into
mainfrom
build_options_base64

Conversation

@pmachapman

@pmachapman pmachapman commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Partial fix for #966.

Requires: sillsdev/machine.py#330.

I will implement build_option constraints separately in another PR, as those will be implemented at the API boundary.


This change is Reviewable

@pmachapman
pmachapman requested review from Enkidu93 and ddaspit July 2, 2026 02:43
@pmachapman
pmachapman force-pushed the build_options_base64 branch from e131616 to ee83242 Compare July 2, 2026 02:59
@codecov-commenter

codecov-commenter commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.74%. Comparing base (d6a912c) to head (02cb18c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ment/Services/StatisticalClearMLBuildJobFactory.cs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #992   +/-   ##
=======================================
  Coverage   72.74%   72.74%           
=======================================
  Files         392      392           
  Lines       21711    21723   +12     
  Branches     2820     2820           
=======================================
+ Hits        15794    15803    +9     
- Misses       4794     4797    +3     
  Partials     1123     1123           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ddaspit ddaspit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit partially reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Enkidu93).

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Enkidu93 partially reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@Enkidu93
Enkidu93 force-pushed the build_options_base64 branch from d65c6c6 to 2262aa6 Compare August 28, 2026 21:18
@Enkidu93
Enkidu93 merged commit ae68c83 into main Aug 28, 2026
1 of 2 checks passed
@Enkidu93
Enkidu93 deleted the build_options_base64 branch August 28, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants