Skip to content

SF-3897 Fix inconsistent Biblical terms tab date format - #4047

Open
Nateowami wants to merge 1 commit into
masterfrom
fix/SF-3897-biblical-terms-date-format
Open

SF-3897 Fix inconsistent Biblical terms tab date format#4047
Nateowami wants to merge 1 commit into
masterfrom
fix/SF-3897-biblical-terms-date-format

Conversation

@Nateowami

@Nateowami Nateowami commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

The original issue was caused by the editor not using the I18nService for date formats. Once that was fixed, the test team pointed out that two locales were showing the time where others were not. If fixed that and also made very use of the date format specify whether to include the time and timezone. This is perhaps more verbose than strictly necessary, but I thought it better to be verbose than let dates be formatted without the developer ever thinking through whether they want time and timezone.

(In general timezone is only included in logs for admins for troubleshooting)

This change is Reviewable

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.09%. Comparing base (9ea2662) to head (62c5c40).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../app/serval-administration/draft-jobs.component.ts 33.33% 0 Missing and 2 partials ⚠️
...val-administration/job-details-dialog.component.ts 0.00% 1 Missing ⚠️
...p/serval-administration/serval-builds.component.ts 0.00% 1 Missing ⚠️
...ipture/ClientApp/src/xforge-common/i18n.service.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4047      +/-   ##
==========================================
- Coverage   81.09%   81.09%   -0.01%     
==========================================
  Files         666      666              
  Lines       43263    43258       -5     
  Branches     7061     7063       +2     
==========================================
- Hits        35085    35078       -7     
- Misses       7013     7014       +1     
- Partials     1165     1166       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@Nateowami
Nateowami deployed to screenshot_diff August 14, 2026 03:19 — with GitHub Actions Active
@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

No screenshot differences — all stories are identical.

View the diff page at: https://pr-4047--sf-screenshot-diffs.netlify.app

@Nateowami
Nateowami deployed to screenshot_diff August 14, 2026 14:08 — with GitHub Actions Active
@Nateowami
Nateowami force-pushed the fix/SF-3897-biblical-terms-date-format branch from fb89dd6 to b576199 Compare August 27, 2026 16:54
@Nateowami
Nateowami force-pushed the fix/SF-3897-biblical-terms-date-format branch from b576199 to 62c5c40 Compare August 27, 2026 21:00
@Nateowami Nateowami added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels Aug 28, 2026
@Nateowami
Nateowami marked this pull request as ready for review August 28, 2026 13:30
@Nateowami
Nateowami deployed to screenshot_diff August 28, 2026 13:33 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant