SF-3897 Fix inconsistent Biblical terms tab date format - #4047
Open
Nateowami wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4047 +/- ##
==========================================
- Coverage 81.09% 81.09% -0.01%
==========================================
Files 666 666
Lines 43263 43258 -5
Branches 7061 7063 +2
==========================================
- Hits 35085 35078 -7
- Misses 7013 7014 +1
- Partials 1165 1166 +1 ☔ View full report in Codecov by Harness. |
Contributor
|
✅ No screenshot differences — all stories are identical. View the diff page at: https://pr-4047--sf-screenshot-diffs.netlify.app |
Nateowami
force-pushed
the
fix/SF-3897-biblical-terms-date-format
branch
from
August 27, 2026 16:54
fb89dd6 to
b576199
Compare
Nateowami
force-pushed
the
fix/SF-3897-biblical-terms-date-format
branch
from
August 27, 2026 21:00
b576199 to
62c5c40
Compare
Nateowami
had a problem deploying
to
screenshot_diff
August 27, 2026 21:08 — with
GitHub Actions
Failure
Nateowami
had a problem deploying
to
screenshot_diff
August 27, 2026 22:47 — with
GitHub Actions
Failure
Nateowami
marked this pull request as ready for review
August 28, 2026 13:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original issue was caused by the editor not using the I18nService for date formats. Once that was fixed, the test team pointed out that two locales were showing the time where others were not. If fixed that and also made very use of the date format specify whether to include the time and timezone. This is perhaps more verbose than strictly necessary, but I thought it better to be verbose than let dates be formatted without the developer ever thinking through whether they want time and timezone.
(In general timezone is only included in logs for admins for troubleshooting)
This change is