Skip to content

rts: answer a snapshot request made on a connection that is gone - #4062

Open
marksvc wants to merge 1 commit into
masterfrom
task/conn-null
Open

rts: answer a snapshot request made on a connection that is gone#4062
marksvc wants to merge 1 commit into
masterfrom
task/conn-null

Conversation

@marksvc

@marksvc marksvc commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

fetchSnapshotByTimestamp called through optional chaining, so when the
handle no longer named a connection the call was skipped entirely and
the
callback was never invoked. The dotnet caller awaits that callback
until it is given up on.

Check for the missing connection and answer with an error, as the
neighbouring fetchSnapshotsByTimestamp already does.


Open in Devin Review


This change is Reviewable

@marksvc
marksvc marked this pull request as draft August 19, 2026 23:34
@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.09%. Comparing base (9ea2662) to head (f6408de).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4062   +/-   ##
=======================================
  Coverage   81.09%   81.09%           
=======================================
  Files         666      666           
  Lines       43263    43263           
  Branches     7061     7087   +26     
=======================================
  Hits        35085    35085           
+ Misses       7013     6998   -15     
- Partials     1165     1180   +15     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@marksvc
marksvc deployed to screenshot_diff August 19, 2026 23:41 — with GitHub Actions Active
fetchSnapshotByTimestamp called through optional chaining, so when the
handle no longer named a connection the call was skipped entirely and
the
callback was never invoked. The dotnet caller awaits that callback
until it is given up on.

Check for the missing connection and answer with an error, as the
neighbouring fetchSnapshotsByTimestamp already does.
@marksvc marksvc added testing not required e2e Run e2e tests for this pull request labels Aug 27, 2026
@marksvc
marksvc marked this pull request as ready for review August 27, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run e2e tests for this pull request testing not required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant