rts: answer a snapshot request made on a connection that is gone - #4062
Open
marksvc wants to merge 1 commit into
Open
rts: answer a snapshot request made on a connection that is gone#4062marksvc wants to merge 1 commit into
marksvc wants to merge 1 commit into
Conversation
marksvc
marked this pull request as draft
August 19, 2026 23:34
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4062 +/- ##
=======================================
Coverage 81.09% 81.09%
=======================================
Files 666 666
Lines 43263 43263
Branches 7061 7087 +26
=======================================
Hits 35085 35085
+ Misses 7013 6998 -15
- Partials 1165 1180 +15 ☔ View full report in Codecov by Harness. |
fetchSnapshotByTimestamp called through optional chaining, so when the handle no longer named a connection the call was skipped entirely and the callback was never invoked. The dotnet caller awaits that callback until it is given up on. Check for the missing connection and answer with an error, as the neighbouring fetchSnapshotsByTimestamp already does.
marksvc
force-pushed
the
task/conn-null
branch
from
August 27, 2026 21:18
9ef2fff to
f6408de
Compare
marksvc
marked this pull request as ready for review
August 27, 2026 21:19
marksvc
had a problem deploying
to
screenshot_diff
August 27, 2026 21:25 — with
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetchSnapshotByTimestamp called through optional chaining, so when the
handle no longer named a connection the call was skipped entirely and
the
callback was never invoked. The dotnet caller awaits that callback
until it is given up on.
Check for the missing connection and answer with an error, as the
neighbouring fetchSnapshotsByTimestamp already does.
Open in Devin Review
This change is