Skip to content

Return compound members metadata as array instead of object for strict ordering - #121

Merged
axelboc merged 2 commits into
mainfrom
compound-order
Mar 3, 2026
Merged

axelboc merged 2 commits into
mainfrom
compound-order

Conversation

@axelboc

@axelboc axelboc commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

See silx-kit/h5web#1765

The new format is consistent with h5wasm's and will fix ordering issues with number-like compound members.

In a second commit, I fix a few issues in the API schema following an AI's suggestions (see comments).

Comment thread docs/_static/api.yaml
Comment thread docs/_static/api.yaml
Comment thread docs/_static/api.yaml Outdated
$ref: '#/components/schemas/shape'
type:
$ref: '#/components/schemas/type'
$ref: '#/components/schemas/fullDtype'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming of the type schema was a bit confusing to me.

Comment thread docs/_static/api.yaml
Comment thread src/h5grove/utils.py Outdated
@axelboc
axelboc requested a review from loichuder March 2, 2026 14:54
Comment thread src/h5grove/utils.py Outdated
@loichuder
loichuder self-requested a review March 3, 2026 08:43

@loichuder loichuder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@axelboc
axelboc merged commit 4932675 into main Mar 3, 2026
2 checks passed
@axelboc
axelboc deleted the compound-order branch March 3, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants