Repository navigation
Replace react-slider with a built-in slider - #2087
Draft
NAThompson wants to merge 1 commit into
Draft
NAThompson wants to merge 1 commit into
NAThompson wants to merge 1 commit into
Conversation
Alternative to silx-kit#2078 without dependency: pointer, keyboard, ARIA, pushing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 15, 2026
Contributor
|
I like this one very much. Not nearly as much code as I thought. I'll need some time to review it but from a quick glance, can you please get Claude to re-expand the touch/focus area of the thumbs of the domain slider so it fills the height of the toolbar? Thanks! 🙏 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #2078: replace
react-sliderwith a small built-inSlider(pointer, keyboard, ARIA, thumbs push each other). No new dependency.🤖 Generated with Claude Code