Repository navigation
Fix desktop WebSocket livelock and temporarily pause Linux CI - #166
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
slashdevcorpse has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughWebSocket transport admission now distinguishes private desktop loopback configurations from other modes. CI workflow contracts and jobs model backlogged Linux lanes as disabled, remove Linux from the unit matrix, and expect skipped aggregate results. ChangesWebSocket admission throttling
Linux CI backlogging
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/server/src/wsTransportAdmission.test.ts`:
- Around line 150-165: Update the wsTransportAdmissionOptionsForServerConfig
overrides in this test to inject a fixed clock with now returning 0, ensuring
the retryAfterMs assertion remains exactly 30_000 across all connection
acquisitions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 8f6fe429-0413-4611-9759-149562f30b1a
📒 Files selected for processing (2)
apps/server/src/nodeHttpServer.tsapps/server/src/wsTransportAdmission.test.ts
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
slashdevcorpse has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
slashdevcorpse
changed the title
There was a problem hiding this comment.
All reported issues were addressed across 4 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
slashdevcorpse has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
coderabbitai
Bot
added
the
ready-to-merge
Merge Queue Status
This pull request spent 8 seconds in the queue, including 1 second running CI. Required conditions to merge
|
1 participant
Summary
mode=desktop, nopublicUrl, and the configured host passes the existingisLoopbackHostpolicy).quality_linux, the Linux unit-matrix entry, ande2e_linux) while keeping Windows validation required and macOS skipped.Root cause and security boundary
The desktop renderer opens bootstrap and feature sockets that share one loopback peer identity. Startup and reconnect cycles depleted the default 10-per-minute pre-auth peer bucket; subsequent retries received HTTP 429 and could remain in a reconnect livelock until the bucket refilled.
The exemption intentionally uses the existing shared loopback predicate. Packaged desktop binds canonical
127.0.0.1; noncanonical desktop bind configurations remain peer-throttled fail-safe. This avoids broadening shared auth, health, trusted-origin, and shutdown policy semantics to all of127/8.Temporary Windows-only CI
quality_linuxande2e_linuxare explicitly skipped.windows-2022.Validation
bun run --cwd apps/server test -- src/wsTransportAdmission.test.ts src/wsRpc.connectionLifecycle.test.tsbun run --cwd scripts test -- lib/workflow-contracts.test.tsbun run workflows:validateSummary by CodeRabbit