Conversation
Merged
R-Cramer4
force-pushed
the
match-float-error
branch
from
September 21, 2026 14:19
851b494 to
b8ca41c
Compare
R-Cramer4
marked this pull request as ready for review
September 21, 2026 14:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now this PR disallows matching on floats. Other types also are represented as floats and we need to decide about allowing matching on them. This PR is for #1307
Current State
Allowed
PercentPhysicalLengthLogicalLengthRemDurationAngleDisallowed
Float32