Skip to content

"Version" is a UI string which must be translated #13412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ogoffart merged 2 commits into from
Oct 19, 2026
Merged

"Version" is a UI string which must be translated #13412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9adf29e
"Version" is a UI string which must be translated
Montel Sep 15, 2026
130ea72
Merge branch 'master' into fix_translate_version
Montel Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/upgrade_version.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
sed -i "s/VersionCheck_[0-9]*_[0-9]*_[0-9]*;/VersionCheck_`echo ${{ github.event.inputs.new_version }} | sed "s/\([0-9]*\)\.\([0-9]*\).\([0-9]*\)/\1/"`_`echo ${{ github.event.inputs.new_version }} | sed "s/\([0-9]*\)\.\([0-9]*\).\([0-9]*\)/\2/"`_`echo ${{ github.event.inputs.new_version }} | sed "s/\([0-9]*\)\.\([0-9]*\).\([0-9]*\)/\3/"`;/" api/rs/slint/lib.rs api/slint-sc/lib.rs

# Version in the AboutSlint widget
sed -i "s/Version [0-9]*\.[0-9]*\.[0-9]*\\\\n/Version ${{ github.event.inputs.new_version }}\\\\n/" internal/compiler/widgets/common/about-slint.slint
sed -i "s/@tr(\"Version {}\", \"[0-9]*\.[0-9]*\.[0-9]*\")/@tr(\"Version {}\", \"${{ github.event.inputs.new_version }}\")/" internal/compiler/widgets/common/about-slint.slint

# Version in the docs (cargo add slint@<VERSION>):
git ls-files | grep "\(^\|/\)docs/.*\.\(md\|rst\)\$" | grep -v "/LICENSES/" | xargs sed --follow-symlinks -i 's/slint@[0-9]\+\.[0-9]\+\.[0-9]\+/slint@${{ github.event.inputs.new_version }}/'
Expand Down
2 changes: 1 addition & 1 deletion internal/compiler/widgets/common/about-slint.slint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export component AboutSlint {
}

Text {
text: "Version 1.19.0\nhttps://slint.dev/";
text: @tr("Version {}", "1.19.0") + "\nhttps://slint.dev/";
font-size: 10px;
horizontal-alignment: center;
}
Expand Down
Loading