chore: 에이전트 세팅 수정 - #824
Conversation
|
Warning Review limit reached
Next review available in: 52 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (32)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
.claude/.codex와 동일한 hooks, skills, permissions 구성을 .cursor에 맞게 추가한다. Co-authored-by: Cursor <cursoragent@cursor.com>
Codex 훅을 settings.json 단일 설정과 .codex/hooks 경로로 통일하고, skill 문서의 교차 경로 참조를 각 도구 디렉터리 기준으로 수정한다. Co-authored-by: Cursor <cursoragent@cursor.com>
SKILL.md와 ingest_universities.py가 프론트엔드 도메인(stage.solid-connection.com)을 API base URL로 지정하고 있어 /admin/** 요청이 전부 404로 실패했다. 실제 API 서버 호스트인 api.stage.solid-connection.com으로 수정. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QJSNGrdcvtczeRHUNAEcj3
SKILL.md와 ingest_universities.py 어디에서도 참조되지 않는 orphan 파일이며, 원본 워크북을 템플릿화하지 말라는 스킬 지침과도 상충함 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011VkhLDubhDSovKNS2SxnQ8
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eca87e065e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| from xml.etree import ElementTree | ||
|
|
||
|
|
||
| APPROVED_DEV_BASE_URL = "https://stage.solid-connection.com" |
There was a problem hiding this comment.
The skill directs operators to use http://localhost:8080 for local and https://api.stage.solid-connection.com for stage, but enforce_dev_url accepts only this different https://stage.solid-connection.com value. Consequently both documented choices are rejected as non-dev targets, while the default targets a host the safety workflow explicitly disallows, so the runner cannot be executed as instructed.
AGENTS.md reference: AGENTS.md:L41-L45
Useful? React with 👍 / 👎.
| parser.add_argument("--admin-email", default=os.environ.get("SOLID_CONNECT_ADMIN_EMAIL")) | ||
| parser.add_argument("--admin-password", default=os.environ.get("SOLID_CONNECT_ADMIN_PASSWORD")) | ||
| parser.add_argument("--access-token", default=os.environ.get("SOLID_CONNECT_ADMIN_ACCESS_TOKEN")) |
There was a problem hiding this comment.
When this runner is used non-interactively, these options encourage passing the stage administrator password or bearer token through argv or inherited environment variables, exposing privileged credentials through shell history, process inspection, CI configuration, or diagnostics. This also directly conflicts with the new skill's requirement to use a no-echo input channel and keep credentials and tokens only in process memory; accept secrets only through such a channel rather than argparse/environment defaults.
Useful? React with 👍 / 👎.
| terms[term_name] = created | ||
| counts["terms_created"] += 1 | ||
|
|
||
| for row in rows: |
There was a problem hiding this comment.
When an approved workbook omits an existing UnivApplyInfo in the same home-university/term scope, apply_rows processes only payload rows and never enumerates or deletes stale records. There is no deletion request or deleted count elsewhere in the runner, and the newly added lookup requires a host ID, so the documented complete-snapshot workflow silently leaves removed universities active.
Useful? React with 👍 / 👎.
| }) | ||
| counts["univ_apply_infos_created"] += 1 | ||
| else: | ||
| response = api.request_json("PATCH", f"/admin/univ-apply-infos/{existing_apply_info['id']}", payload) |
There was a problem hiding this comment.
When an existing row has a value but the approved snapshot intentionally leaves that field blank, apply_payload sends null through this PATCH, while UnivApplyInfo.update ignores every null argument. The stale value therefore remains; verification subsequently marks the import failed but cannot correct or roll back the persisted update, making blanking fields through the importer impossible.
Useful? React with 👍 / 👎.
Claude Code에 동일 기능의 내장 review 스킬이 기본 제공되어 중복 제거 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011VkhLDubhDSovKNS2SxnQ8
enforce_dev_url이 stage base URL만 허용해, SKILL.md에서 안내하는 local 환경 선택 시 refusing non-dev target 에러로 막히던 문제 해결 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011VkhLDubhDSovKNS2SxnQ8
1 participant
관련 이슈
작업 내용
기존 claude code 설정에 맞게 codex용 AGENTS.md, .codex를 작성했습니다.
post-edit-check 훅에서 검증 결과가 에이전트에게 제대로 전달되지 않았던 문제를 수정했습니다.
지원 대학을 적재하는 스킬을 추가했습니다. 관련해서 불필요한 로직들을 수정 및 제거했습니다.
AS IS: 지원 대학 파일을 마크다운 테이블 형식으로 힘들게 변환하여 어드민 웹에 접속하여 적재한다.
TO BE: 지원 대학 파일만 간편하게 스킬 인자로 넘겨주어 적재한다.
특이 사항
리뷰 요구사항 (선택)