Fully revert ACPI SCI Handler to Bookworm Behavior - #618
Open
croos12 wants to merge 1 commit into
Open
Conversation
revert-acpi-osl-use-threaded-irq-for-sci.patch puts the ACPI SCI back on
a non-threaded handler requested with plain IRQF_SHARED. Three later
upstream commits had adjusted the surrounding code to suit the threaded,
IRQF_ONESHOT SCI:
8e57de4307 ACPI: OSL: Use spin locks without disabling interrupts
655a6e7c0d ACPI: EC: Use a threaded handler for dedicated IRQ
8f812373d1 platform/x86: intel: int0002_vgpio: Pass IRQF_ONESHOT to
request_irq()
platform-x86-int0002-remove-irqf-oneshot.patch already restored the
INT0002 side. Revert the other two so the ACPI lock primitives and the
EC dedicated IRQ also match the SCI handler the series restores.
Keep both ordered after revert-acpi-osl-use-threaded-irq-for-sci.patch,
and record in the series file that the four are a dependent set: applying
the SCI revert without them, or reordering them, leaves the interrupt
configuration inconsistent.
Signed-off-by: Connor Roos <croos@nvidia.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
dgsudharsan
approved these changes
Aug 28, 2026
Contributor
|
What’s the status of fixing this upstream? |
paulmenzel
suggested changes
Aug 28, 2026
| @@ -0,0 +1,45 @@ | |||
| From: Connor Roos <croos@nvidia.com> | |||
| Date: 2026-08-05 | |||
| Subject: Revert "ACPI: EC: Use a threaded handler for dedicated IRQ" | |||
Contributor
There was a problem hiding this comment.
Please use git format-patch formatted patches.
Contributor
Author
@paulmenzel let me look at the process for including this upstream first. I basically need to incorporate three commits there because of #580. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Reverting
7a36b901a6eb("ACPI: OSL: Use a threaded interrupt handler for SCI") puts the ACPI SCIback on a non-threaded handler requested with plain IRQF_SHARED. Three later upstream commits had
adjusted the surrounding code to suit the threaded, IRQF_ONESHOT SCI:
8e57de4307dropped the interrupt disable from the ACPICA spin lock primitives.655a6e7c0dthreaded the EC dedicated IRQ handler.8f812373d1added IRQF_ONESHOT to the INT0002 request.Restore all three to their pre-
7a36b901a6ebbehavior, so the ACPI locking, the EC dedicated IRQ,and the INT0002 flags match the SCI handler we restored.
Work item tracking
How I did it
revert-acpi-osl-use-threaded-irq-for-sci.patch(Revert "ACPI: OSL: Use a threaded interrupt handler for SCI" #580) andplatform-x86-int0002-remove-irqf-oneshot.patch(Cherry-pick int0002 IRQF_ONESHOT removal on top of the SCI revert #607), which already carries the INT0002 side.revert-acpi-osl-use-spin-locks-without-disabling-interrupts.patchandrevert-acpi-ec-use-threaded-handler-for-dedicated-irq.patch.series, matching upstreammaster, with a comment notingthey are a dependent set.
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Fully revert ACPI SCI Handler to Bookworm Behavior