Subtree cleanups - #35
Merged
Merged
Conversation
Same bug as the main tree's prove_nodes: keys diverging from an internal node's prefix with a 0 bit sort before the matching band, so the one-sided partition_point dropped every matching key whenever a diverge-left key came first, breaking chained proofs.
The non-aligned branch guarded the next-byte read with i < a.len() while indexing a[i + 1], panicking whenever a comparison scanned to self's last byte — e.g. any lookup in a tree where two keys share a ~255-bit prefix. Leaving the low bits zero is safe: a mismatch they introduce lies beyond max_bit_len and is clamped away.
Delete now rejects keys diverging from an internal node's prefix with KeyNotFound instead of descending and surfacing IncompleteProof at a hash node. Merge no longer absorbs interior None nodes — a proof that cannot compute its own root must not merge into a valid-looking one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.