Add support for arbitrary doc types - #137
Open
sbihel wants to merge 1 commit into
Open
Conversation
It required addressing the following problems: 1. Some checks were hardcoded for mDLs (e.g. expecting the mDL doctype in a presentation response). This is addressed by adding more validation options through `MdocProfile`. 2. The 18013-5 certificates profile is only normative for mDLs. This is addressed by introducing a `CertificateProfile` trait and generics (like we do already for e.g. revocation fetching). And to make sure the new API fits the requirement of existing doc types, I have added native support for ISO PIDs, EUDI PIDs, and EU Age Verification doc types. REF ACC-1912
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It required addressing the following problems:
in a presentation response). This is addressed by adding more
validation options through
MdocProfile.addressed by introducing a
CertificateProfiletrait and generics(like we do already for e.g. revocation fetching).
And to make sure the new API fits the requirement of existing doc types,
I have added native support for ISO PIDs, EUDI PIDs, and EU Age
Verification doc types.
REF ACC-1912