Skip to content

feat(chart) :: turn a reference line into a band - #1377

Merged
lovasoa merged 2 commits into
sqlpage:mainfrom
81reap:reference/3-band
Aug 26, 2026
Merged

feat(chart) :: turn a reference line into a band#1377
lovasoa merged 2 commits into
sqlpage:mainfrom
81reap:reference/3-band

Conversation

@81reap

@81reap 81reap commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Motivation

#1374

Description

  • Adding yline_end or xline_end to a reference row turns its line into a band that reaches to that value. Label and color work the same as on a line.
  • Update the two documentation examples — the throttling threshold becomes a band up to ymax, and the incident on the latency chart covers its whole duration — and extend the changelog entry.

Testing

  • The two reference-line browser tests now each check both shapes: one line and one band on the y axis, and one line and one band on the x axis, with both labels visible.

  1. fix(chart) :: line series up on a category axis for every chart type #1371 :: fix(chart) :: line series up on a category axis for every chart type
  2. feat(chart) :: draw horizontal reference lines #1375 :: feat(chart) :: draw horizontal reference lines
  3. feat(chart) :: draw vertical reference lines #1376 :: feat(chart) :: draw vertical reference lines
  4. feat(chart) :: turn a reference line into a band #1377 :: feat(chart) :: turn a reference line into a band ← this PR

@81reap
81reap marked this pull request as ready for review August 25, 2026 22:44
@81reap

81reap commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

@lovasoa seems like we accidentally pulled in a duplicated change log when mergeing mainline into #1401 . I generally find that always rebasing instead of mergeing avoids these kinds of issues. always happy to rebase my PRs and push back up as well :)

@lovasoa
lovasoa merged commit a49ad65 into sqlpage:main Aug 26, 2026
51 checks passed
@81reap
81reap deleted the reference/3-band branch August 26, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants