feat(chart) :: turn a reference line into a band - #1377
Merged
Conversation
This was referenced Aug 13, 2026
This was referenced Aug 22, 2026
81reap
force-pushed
the
reference/3-band
branch
from
August 25, 2026 22:44
f57edb5 to
b1051b6
Compare
81reap
marked this pull request as ready for review
August 25, 2026 22:44
Contributor
Author
|
@lovasoa seems like we accidentally pulled in a duplicated change log when mergeing mainline into #1401 . I generally find that always rebasing instead of mergeing avoids these kinds of issues. always happy to rebase my PRs and push back up as well :) |
lovasoa
approved these changes
Aug 26, 2026
lovasoa
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#1374
Description
yline_endorxline_endto a reference row turns its line into a band that reaches to that value. Label and color work the same as on a line.ymax, and the incident on the latency chart covers its whole duration — and extend the changelog entry.Testing