Skip to content

ROX-36481: [UI] Add Top prefix to aggregate CVSS/CVE Severity columns - #22517

Open
alkmim wants to merge 1 commit into
masterfrom
alkmim/ROX-36481-add-missing-top-prefix
Open

ROX-36481: [UI] Add Top prefix to aggregate CVSS/CVE Severity columns#22517
alkmim wants to merge 1 commit into
masterfrom
alkmim/ROX-36481-add-missing-top-prefix

Conversation

@alkmim

@alkmim alkmim commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Description

"CVSS" and "CVE severity" column headings changed to "Top CVSS" and "Top CVE Severity" on pages where the values are aggregated, pages:

  • Single CVE: /main/vulnerabilities/*/cves/
  • Single Image: /main/vulnerabilities/*/images/
  • Single Deployment: /main/vulnerabilities/*/deployments/

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Deployed the UI and manually checked the fields. I also confirmed that filtering the columns is working.

CVE page

image image

Deployment Page

image image

Image Page

image image

@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@alkmim
alkmim force-pushed the alkmim/ROX-36481-add-missing-top-prefix branch from 11b3603 to 9f831bd Compare August 27, 2026 16:21
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 40f7d3c0-7459-4d20-9735-05ee7e07de4c

📥 Commits

Reviewing files that changed from the base of the PR and between 081b72d and 929ab3f.

📒 Files selected for processing (4)
  • ui/apps/platform/cypress/integration/vulnerabilities/workloadCves/deploymentSingle.test.ts
  • ui/apps/platform/src/Containers/Vulnerabilities/WorkloadCves/Tables/AffectedImagesTable.tsx
  • ui/apps/platform/src/Containers/Vulnerabilities/WorkloadCves/Tables/DeploymentVulnerabilitiesTable.tsx
  • ui/apps/platform/src/Containers/Vulnerabilities/WorkloadCves/Tables/ImageVulnerabilitiesTable.tsx

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • UI Improvements

    • Updated vulnerability tables to clearly label aggregate metrics as “Top CVE severity” and “Top CVSS.”
    • Applied consistent terminology across affected images, deployment vulnerabilities, and image vulnerabilities views.
  • Tests

    • Updated coverage to verify the revised “Top CVE severity” table heading.

Walkthrough

The pull request renames workload CVE table labels to distinguish top severity and CVSS values. The related Cypress assertion now expects the updated severity label.

Changes

Workload CVE label updates

Layer / File(s) Summary
Update workload CVE table labels
ui/apps/platform/src/Containers/Vulnerabilities/WorkloadCves/Tables/*Table.tsx
Affected images, deployment vulnerabilities, and image vulnerabilities tables now display Top CVE severity and Top CVSS labels. Cell data labels use the same terminology.
Align Cypress assertion
ui/apps/platform/cypress/integration/vulnerabilities/workloadCves/deploymentSingle.test.ts
The deployment vulnerabilities test now expects the Top CVE severity header.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 929ab

This change clarifies aggregated vulnerability column headings without altering the underlying values or behavior, and no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: dvail, alanonthegit

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 4 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the primary UI change: adding the "Top" prefix to aggregate CVSS and CVE severity column headings.
Description check ✅ Passed The description follows the required template, identifies the affected pages, records documentation and quality checks, explains the modified existing test, and documents manual validation with screen…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description follows the required template, identifies the affected pages, records documentation and quality checks, explains the modified existing test, and documents manual validation with screenshots.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch alkmim/ROX-36481-add-missing-top-prefix

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

🚀 Build Images Ready

Images are ready for commit 929ab3f. To use with deploy scripts:

export MAIN_IMAGE_TAG=5.0.x-135-g929ab3f3ea

@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.38%. Comparing base (5fd9c15) to head (ed0d99b).

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #22517       +/-   ##
===========================================
+ Coverage   50.06%   51.38%    +1.32%     
===========================================
  Files         791     2876     +2085     
  Lines       62717   180438   +117721     
===========================================
+ Hits        31397    92714    +61317     
- Misses      28003    79615    +51612     
- Partials     3317     8109     +4792     
Flag Coverage Δ
go-unit-tests 51.38% <ø> (+1.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alkmim
alkmim marked this pull request as ready for review August 28, 2026 06:31
@alkmim
alkmim requested a review from a team as a code owner August 28, 2026 06:31
@alkmim alkmim self-assigned this Aug 28, 2026
@alkmim alkmim added the auto-retest PRs with this label will be automatically retested if prow checks fails label Aug 28, 2026
@alkmim
alkmim requested a review from dcaravel August 28, 2026 06:31
@alkmim alkmim changed the title ROX-36481: [UI] Add missing Top prefix to aggregate CVSS and CVE Severity columns ROX-36481: [UI] Add Top prefix to aggregate CVSS/CVE Severity columns Aug 28, 2026
@alkmim
alkmim force-pushed the alkmim/ROX-36481-add-missing-top-prefix branch 2 times, most recently from ab8c426 to 5a1d808 Compare August 31, 2026 15:24

@dcaravel dcaravel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alkmim
alkmim enabled auto-merge (squash) August 31, 2026 16:55
@alkmim
alkmim force-pushed the alkmim/ROX-36481-add-missing-top-prefix branch 2 times, most recently from 383ab8d to ace54e3 Compare August 31, 2026 17:53
@bradr5

bradr5 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Is this not also true for virtual machine vulnerabilities?

@alkmim
alkmim disabled auto-merge August 31, 2026 18:37
@alkmim
alkmim force-pushed the alkmim/ROX-36481-add-missing-top-prefix branch from ace54e3 to ed0d99b Compare August 31, 2026 18:57
@alkmim
alkmim force-pushed the alkmim/ROX-36481-add-missing-top-prefix branch from ed0d99b to 929ab3f Compare August 31, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ui auto-retest PRs with this label will be automatically retested if prow checks fails

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants