Repository navigation
Fix exit codes, date checks and knowledge base rebuild end date - #88
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes problems found while reviewing #87 (development into main).
rebuild-kbprocessed and cached today's incomplete data. The next day's blocklists would then miss attacks that arrived after the rebuild. The rebuild now stops at yesterday, and a start date of today is rejected.run-modelswith a start date after the end date did nothing and exited with success. It now prints an error and exits with code 1.generate_historical_blocklists.pyimportedlib.aip..., which fails with the documentedPYTHONPATH=libsetup. It now importsaip...like the rest of the code.Testing
rebuild-kbfor today each print an error and exit with code 1.generate_historical_blocklists.pyimports without errors.