Conversation
SaxonF
added this pull request to stack #6600
September 14, 2026 11:20
Object-valued query parameters in the v2 spec all declare
`style: deepObject`, which puts one `param[key]=value` pair per entry on
the wire. The client serialized them as a JSON blob instead, so a caller
passing `page: { size: 100 }` reached the server with no page size and no
cursor at all — a paginated walk silently returned the first
default-sized page forever.
Expand every object-valued query parameter into its own pairs. Arrays are
untouched: those are the repeated-key form `normalizeUrlValue` already
handles.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
SaxonF
force-pushed
the
notebooks/02-api-deepobject-query
branch
from
September 14, 2026 23:50
a1c9cf8 to
3ee8ed9
Compare
SaxonF
removed this pull request from stack #6600
September 15, 2026 00:30
SaxonF
added this pull request to stack #6612
September 15, 2026 00:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Object-valued query parameters in the v2 spec all declare
style: deepObject, which puts oneparam[key]=valuepair on the wire per entry. The client serialized them as a JSON blob instead, so a caller passingpage: { size: 100, after: cursor }reached the server with no page size and no cursor at all — a paginated walk silently returned the first default-sized page forever, with no error to notice.What changed
buildRequestnow expands every object-valued query parameter into its ownparam[key]=valuepairs. Arrays are excluded: those are the repeated-key formnormalizeUrlValuealready handles. Entries whose value isundefinedare dropped rather than sent empty.Reviewer notes
The expansion is applied to all object-valued query parameters rather than driven by a per-parameter style recorded in the generated contract, because every object-valued query parameter in the spec is
deepObject. If that ever stops being true, the contract needs to carry the style and this needs to read it.This also un-blocks the
page/filterparameters onv2-list-organization-members,v2-list-organization-projects, andv2-list-organization-github-connections, which the README previously documented as unusable. The README section is updated accordingly.