Skip to content

feat(cli): add --target to feedback add - #7331

Draft
antlio wants to merge 2 commits into
developfrom
anthonylio/depr-698-explore-agent-feedback-capabilities-in-supabase-docs
Draft

antlio wants to merge 2 commits into
developfrom
anthonylio/depr-698-explore-agent-feedback-capabilities-in-supabase-docs

Conversation

@antlio

@antlio antlio commented Oct 26, 2026

Copy link
Copy Markdown

Summary

  • when comes a docs problem, docs team cannot see which page the agent read, or what the page said at that time
  • supabase feedback add accepts a repeatable --target flag, so a docs report can name up to 3 docs sections
  • cli stores the targets in the existing metadata object, so the table and the submit_interfaces_feedback rpc do not change
  • telemetry records --target by name only, never its value
  • the mcp server sends the same shape in feat: agent feedback capabilities for docs mcp#488

Linked issue

[Closes #](linear: DEPR-698)

  • The linked issue is open and carries the open-for-contribution label (or I'm a Supabase maintainer).

Checklist

  • The PR title follows Conventional Commits (e.g. fix(cli): …).
  • Tests added or updated for the change.
  • From the repository root, pnpm check:all passes; relevant package tests pass for every touched workspace, and pnpm types:check passes for each touched TypeScript workspace (or workspace declaring it).

@antlio antlio self-assigned this Oct 26, 2026
@kanadgupta

Copy link
Copy Markdown
Member

/ai-review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

Both independent reviews were available; Codex reported no findings. Confirmed Claude’s two documentation nits and one minor Unicode length-validation inconsistency. No additional issues identified. Tests were not run.

Findings

Severity Location Category Sources Claim
🟡 MINOR apps/cli/src/commands/feedback/add/add.handler.ts:44 correctness claude The quote and heading limits count UTF-16 code units, rejecting some strings below the documented character limits.
⚪ NIT apps/cli/src/commands/feedback/add/add.command.ts:29 documentation claude The --target help text omits the accepted /llms-full.txt and /llms/ URL forms.
⚪ NIT apps/cli/src/shared/feedback/feedback-client.service.ts:28 documentation claude The targets comment calls its inline object type a type alias, but no type alias is declared.

Stats

Claude findings: 3 · Codex findings: 0 · Confirmed: 3 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: manual · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

Comment thread apps/cli/src/commands/feedback/add/add.command.ts Outdated
Comment thread apps/cli/src/commands/feedback/add/add.handler.ts Outdated
Comment thread apps/cli/src/shared/feedback/feedback-client.service.ts Outdated
@antlio
antlio force-pushed the anthonylio/depr-698-explore-agent-feedback-capabilities-in-supabase-docs branch from 52ec347 to 1597233 Compare October 27, 2026 13:51

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants