Repository navigation
Conversation
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews were available. Claude's single finding is confirmed for --legacy-bundle=false: the new presence-based guard incorrectly disables API fallback despite no explicit request for local bundling. Codex reported no findings.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| 🟡 MINOR | apps/cli/src/shared/functions/deploy.ts:2592 |
correctness |
claude | Passing --legacy-bundle=false now fails when Docker is unavailable instead of retaining the default API fallback. The guard treats explicitly disabling legacy bundling as explicitly requesting local bundling. |
Stats
Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
…dling-falls-back-to-api-bundling
CLI benchmark: no changes foundCommit
API calls: unchanged for all 7 commands. Binary size: 133.8 MB, unchanged. Details: timing ranges, API calls per command, slowest phasesTiming ranges
API calls per command
Slowest phasesNo command moved beyond noise, so there are no phase deltas. Comment |
TL;DR
stops
functions deploy --use-api=falseand--use-dockerdeploying through the api when docker isn't runningwhats improved/fixed?
with docker down, an explicit local bundler flag printed
WARNING: Docker is not runningand then uploaded the sources for server side bundling, exiting 0so a deploy that asked for local docker bundling silently got a server side bundle instead
how?
--use-api=false,--use-dockeror--legacy-bundlewith docker down now fails withDocker is not running. Start Docker to bundle Functions locally, or deploy with --use-api.before deploying with no bundler flag it still warns and falls back to the api, exactly as before...
ref: