Repository navigation
test(stack): name the failing psql call when Commands stderr is empty - #7457
Conversation
Reset stdout and stderr before each expected psql failure and attach the call label, exit code and captured output to the assertions, so a Podman run that loses stderr shows which call it was and how psql exited. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MBEk1PhFmm5bGsyrcpQfsk
|
/ai-review Generated by Claude Code |
CLI benchmark (Lightweight Commands): no changes foundCommit
API calls: unchanged for all 7 commands. Binary size: 134.0 MB, unchanged. Details: timing ranges, API calls per command, slowest phasesTiming ranges
API calls per command
Slowest phasesNo command moved beyond noise, so there are no phase deltas. Comment |
There was a problem hiding this comment.
Superseded by a newer AI review
🤖 AI Review
Both independent reviews reported no findings. Code inspection confirms that the buffer resets isolate each psql failure and the diagnostic messages preserve existing assertions. No additional issues found. Tests were not run.
Findings
No issues found.
Stats
Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews reported no findings. Reading the full diff and surrounding checked-out code confirmed that the changes isolate captured output and add failure diagnostics without weakening assertions. No issues found. Tests were not run.
Findings
No issues found.
Stats
Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: manual · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
Flaky test check: ✅ no flaky testsCommit Each execution is a separate Vitest process; |
TL;DR
Diagnostic only. The cause is still unknown, so the next failure will say which psql call lost its stderr and how that call exited.
Commands.integration.test.ts › podman runs SQL from stdin, streams a dump, and returns client failure: on Podman, psql exited non-zero but captured stderr was empty (expected '' to contain 'missing_column'). The vitest frame didn't show which of the two expected-failure calls fired, and stderr was shared across calls, so the report couldn't tell an attach that dropped output apart from a different exit path. Stdout and stderr are now reset before each expected psql failure, and both assertions carry the call label, the exit code and the captured stdout/stderr.ref
spotted in: https://github.com/supabase/cli/actions/runs/41469215904/job/125358056261 (green rerun: https://github.com/supabase/cli/actions/runs/41469215904/job/125360621750)
Generated by Claude Code