Fall back to internal URL standardization - #234
Merged
Conversation
…1942 changed how URL standardization worked in macOS 27.0. Perhaps the new implementation is more correct, but it is inconsistent with the other implementations o_O For appleOS 27.0 and above, I have changed it to fall back to the internal URL standardization, which itself was taken from FoundationEssentails before they changed it in the above PR. AFAICT this is the only failing test.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
==========================================
+ Coverage 92.98% 93.00% +0.02%
==========================================
Files 72 72
Lines 3748 3748
==========================================
+ Hits 3485 3486 +1
+ Misses 263 262 -1 ☔ View full report in Codecov by Harness. |
Using version checks with `anyAppleOS` is not ready in this project since we must also support older Xcode versions, which have it under a feature flag.
swhitty
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests failed on Xcode 27 because of a change in URL standardisation behaviour. swiftlang/swift-foundation#1942 changed it. Perhaps the new implementation is more correct, but it is inconsistent with the other implementations in FlyingFox which support other OS versions.
For appleOS 27.0 and above, I have changed it to fall back to the internal URL standardization, which itself was taken from FoundationEssentails before they changed it in the above PR.
AFAICT this is the only failing test on macOS 27.0 (so far…………)
Does it break in macOS 26? Hopefully not.