Repository navigation
Fix module reported deprecated #1705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
heckj
wants to merge
7
commits into
swiftlang:main
Choose a base branch
from
heckj:fix-module-reported-deprecated
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6f3b92a
Add failing test for a module without availability information being …
heckj c2c4cf6
Don't consider pages without any availability information to be depre…
heckj 0256f40
Populate the module's availability instead of special-casing isDeprec…
heckj 30053f9
Update module platform expectations in default availability tests
heckj ee2b914
Add tests for module availability with Info.plist default availability
heckj 453f6ff
dropping test for legacy functionality deprecated in #1690
heckj d0dc4c6
Revert module availability population; keep isDeprecated guard for em…
heckj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: This test helper might be a bit too specialized with it only being called from a single test. You could see if it makes sense to move it into It could move into that test as an inner function.
Alternatively, if there are more tests that need both the RenderNode and the TopicRenderReference; maybe it would make sense for a helper function to return both. A caller could restructure the return value as
let (renderNode, _) = try ...if they only need one of the values. That way theassertIsNotDeprecated(...)helper could likely go away completely.