fix: show passphrase toast on sheet - #1165
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Greptile SummaryThe PR renders the existing app-wide toast inside the hardware-wallet passphrase modal so wrong-passphrase errors remain visible above the sheet.
Confidence Score: 5/5The PR appears safe to merge with no actionable regressions identified. The sheet-local host observes the existing toast state and forwards the established dismissal and gesture callbacks while placing the toast above the modal that previously obscured it.
|
| Filename | Overview |
|---|---|
| app/src/main/java/to/bitkit/ui/screens/transfer/hardware/HwPassphrasePromptSheet.kt | Adds an in-sheet host for the shared toast state, preserving existing dismissal, pause, resume, and haze behavior without an established defect. |
| changelog.d/next/1161.fixed.md | Accurately documents that wrong-passphrase errors are now visible over the hardware transfer passphrase sheet. |
Reviews (1): Last reviewed commit: "fix: harden passphrase sheet toast host" | Re-trigger Greptile
jvsena42
requested changes
Aug 18, 2026
jvsena42
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1161
This PR shows the wrong-passphrase error toast on top of the hardware transfer passphrase sheet.
Description
Entering the wrong passphrase on Transfer to Spending already refused the sign and sent the error toast, but the toast sat behind the modal sheet. It was only visible after Cancel. The toast now renders inside the sheet, with the same frosted style as elsewhere.
Preview
Screen_Recording_20260819_103340_Bitkit.Regtest.mp4
QA Notes
Manual Tests
regression:same flow with the correct passphrase → Continue: sheet closes and signing proceeds as before.Automated Checks
TransferViewModelTest.ktis unchanged (toast is still sent; this PR only changes where it is drawn).compileDevDebugKotlinpassed.