Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The allocation-size calculation introduces signed integer overflow for large positive message-supplied image lengths.
1 open issue
What changed in this PR
This PR addresses heap corruption when saving library images received from the webview.
Changes:
- Extracts the image payload directly from the JSON string without adding serialization quotes.
- Bounds Base64 decoding and writes the returned byte count.
- Adds validation and error handling for allocation and file operations.
| File | Description |
|---|---|
| T3000/BacnetWebView.cpp | Updates image-save handling and adds output bounds to the Base64 decoder. |
Review effort: Balanced
| if (temp_ret == NULL) | ||
| // The buffer is sized from the reported length and the decoder is bounded by it, | ||
| // so a malformed/truncated payload can never overrun the allocation. | ||
| char* ret_result = (char*)malloc(sizeof(char) * (file_length + 4)); //申请返回字符串空间 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.