fix: handle Textile links with a trailing > and no closing tag#89
Closed
santhreal wants to merge 2 commits into
Closed
fix: handle Textile links with a trailing > and no closing tag#89santhreal wants to merge 2 commits into
santhreal wants to merge 2 commits into
Conversation
_rightanglebracket assumed urlLeft always matched a closing HTML tag. Links like "link":http://example.com> left m as None and raised AttributeError. Treat a bare trailing '>' like other end punctuation.
Member
|
Hi @santhreal, Thank you so much for putting this together! It looks like this issue is already fully resolved in the Since the crash is fixed and the output is aligned with upstream on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
textile.core.Textile._rightanglebracket hits AttributeError when "link":http://example.com>. This PR fixes the regression with a focused test covering the case.