Skip to content

fix(release): expose encoder and compliance package sizes - #310

Merged
thedavidweng merged 1 commit into
mainfrom
fix/encoder-size-report
Oct 19, 2026
Merged

thedavidweng merged 1 commit into
mainfrom
fix/encoder-size-report

Conversation

@thedavidweng

@thedavidweng thedavidweng commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

Summary

 package-report.components
+ encoder: Contents/MacOS/ffmpeg
+ encoder_compliance: Contents/Resources/AudioEncoder/**

Expose the bundled encoder and matching source/license footprint in the existing release size artifact and workflow summary (#289). Total logical bytes and production optimization remain unchanged.

Evidence

  • Before: local export distribution's ~17.6 MB was grouped under other.
    After: python3 native/scripts/test-package-report.py passes, partitioning encoder/source/license bytes and excluding duplicate symlinks; warnings-as-errors 36 Core +19 App tests and pre-push release checks pass.
  • Fresh same-source 1b0c043 arm64 comparison: -O DMG 40,530,798 bytes; -Osize 40,538,038 (+7,240). Both optimized tests, installed export/resource/SIGINT smoke pass. Keep -O; no release assets changed.

Merge Danger

Door: two-way

Blast Radius: reporting

Only component categorization in JSON changes; consumers should tolerate the two additional keys.

Summary by CodeRabbit

  • Improvements
    • Package size reports now break out encoder and audio encoder compliance assets as separate categories, providing a more detailed view of the app’s component sizes. These amounts are included in the existing component totals.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 102a4be4-7d82-41cf-98c6-3ce8075199ed
📥 Commits

Reviewing files that changed from the base of the PR and between dcc27c3 and 1d45981.

📒 Files selected for processing: 2
  • native/scripts/package-report.py
  • native/scripts/test-package-report.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The package report now tracks bytes for the ffmpeg executable and files under AudioEncoder. The test fixture includes these files and checks their category totals and the updated app total.

Changes: Encoder package reporting

Layer / File(s) Summary
Encoder classification and validation
native/scripts/package-report.py, native/scripts/test-package-report.py
The report adds encoder and encoder_compliance totals, and classifies the ffmpeg executable and AudioEncoder files. The test fixture adds encoder-related files and a symlink, then checks the category totals and updated app size.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 1d459

The new encoder size categories have no identified incompatible release-report consumer. This change is mergeable after normal checks.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: exposing encoder and compliance package sizes in release reporting.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kilo-code-bot

kilo-code-bot Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • native/scripts/package-report.py - Adds encoder and encoder_compliance categories, classifying Contents/MacOS/ffmpeg and files under Contents/Resources/AudioEncoder/. Symlinks remain excluded from logical byte totals.
  • native/scripts/test-package-report.py - Adds encoder fixture files and a symlink, verifies app_bytes=450 and encoder_compliance=170. Math verified correct.

Reviewed by free · Input: 95.8K · Output: 11.3K · Cached: 177.2K

@thedavidweng
thedavidweng merged commit 909d15e into main Oct 19, 2026
19 of 21 checks passed
@thedavidweng
thedavidweng deleted the fix/encoder-size-report branch October 19, 2026 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant