Fix backslash round trips in set_key - #682
Closed
mjq2020 wants to merge 1 commit into
Closed
Conversation
mjq2020
marked this pull request as ready for review
August 14, 2026 01:48
Owner
|
Hey @mjq2020 - thanks for jumping on this, and for the thorough test notes. I'm consolidating the #661 backslash round-trip work into #680, which takes the same escape-on-write approach and also patches the parser so a value ending in a backslash can't eat the closing quote (and the line right after it). Closing this in its favor - there were a few solid PRs for this one and I had to pick a single base to build on. Really appreciate the help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set_keyRoot cause
set_keyescaped only single quotes, while the single-quoted parser decodes both\\and\'. Consecutive backslashes were therefore collapsed when the file was read back.Tests
.venv-task/bin/ruff format --check src tests.venv-task/bin/ruff check ..venv-task/bin/pytest tests/test_main.py -q(119 passed)PATH="$PWD/.venv-task/bin:$PATH" .venv-task/bin/pytest -q --ignore=tests/test_cli.py(187 passed)PATH="$PWD/.venv-task/bin:$PATH" .venv-task/bin/pytest tests/test_cli.py -q -k "not test_run_with_command_flags"(39 passed, 1 deselected)The excluded CLI test invokes GNU-only
printenv --version, which is unsupported by macOS BSDprintenv; it is unrelated to this change.Fixes #661