build(solidity): align runtime types with Node 24 - #4300
Open
mswilkison wants to merge 1 commit into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align both packages' explicit type dependencies with the target runtime:
@types/node24.13.3,@types/mocha10.0.10 for Hardhat 2's Mocha 10 runner, and@types/chai4.3.20 for Chai 4. Keep the TypeScript 6 globals lists unchanged. Chai 5 and Mocha 11 belong with their runtime upgrades in #4209.Stacked on #4299; coordinate landing with the Node 24 runtime upgrade in #4205. Closes #4215.
Validation on Node 24.11.1 / Yarn 4.8.1: installs and both full strict typechecks pass; both export compilers pass, including ECDSA's install-time
preparecommand. No source changes were required for the newer declarations.