Repository navigation
Set each export beside its tidymodels counterpart; order eval_time as tune does - #165
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds benchmarks/export-surface.R, which pairs each package-owned export, each method of an exported generic and each result column with its tune, finetune, workflowsets or hardhat counterpart, and cairn/references/export-surface-review.md with a kept, changed or proposed verdict for each difference.
The one code change: the workflow and model_spec methods of nested_tune_bayes() and nested_tune_sim_anneal() now list eval_time before objective and initial, in tune_bayes()'s and tune_sim_anneal()'s order. These arguments come after ..., so no call changes. test-argument-order.R checks the order.