Repository navigation
Cut the inner-design tuner test matrix and narrow the time-series help to the tested set - #168
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes 31 time-series test blocks: the two inner-design tuner files (
test-time-series-inner-bayes-anneal.R,test-time-series-inner-race.R), the four workflow-map blocks that setfnto a non-grid tuner on an inner sliding-period design, and the three grid final-fit blocks on sliding outer designs. Each of the four non-grid tuners keeps its run with an inner sliding design on the sliding-window pair, and the Bayesian final fit on the sliding-window outer design stays.In CI run 39525408946 the deleted blocks took 15.3% to 16.4% of summed block time on each of the five check legs.
The
Time-series designssection of?nested_resamplesand the time-series bullets ofNEWS.mdnow name only the combinations a remaining test runs. Coverage ofR/is unchanged (6352 lines, same hit-or-miss status at both commits).