Repository navigation
feat(continental_ars548_ros_wrapper): migrate ContinentalARS548RosWrapper to agnocast_wrapper::Node - #458
Closed
Koichi98 wants to merge 3 commits into
Closed
feat(continental_ars548_ros_wrapper): migrate ContinentalARS548RosWrapper to agnocast_wrapper::Node#458Koichi98 wants to merge 3 commits into
Koichi98 wants to merge 3 commits into
Conversation
…wrapper::Node-compatible Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>
Koichi98
force-pushed
the
apply_agnocast_continental_ars548
branch
from
July 23, 2026 04:50
2744af4 to
45de9ce
Compare
This was referenced Jul 23, 2026
…pper to agnocast_wrapper::Node (Method 2) Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>
Koichi98
force-pushed
the
apply_agnocast_continental_ars548
branch
from
July 27, 2026 03:46
45de9ce to
eaedd42
Compare
Contributor
Author
|
Superseded: rebased onto #469 (feat/agnocast-core-node-compat) and moved to a fork-internal review PR (Koichi98#2). Will be merged into #469, then #469 into main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
Depends on #467 (Stage 2: adopt synced
agnocast_wrappercore), the sharednebula_core_roscompatibility PR (SyncToolingWorker), and thenode.cppbuild wiring (Stage 2 track). Sibling of the nebula_hesai agnocast application PR.Description
Migrates
ContinentalARS548RosWrapper(and itsdecoder/hw_interfacehelpers) fromrclcpp::Nodetonebula::agnocast_wrapper::Node. Publisher/subscription/service/diagnostic members switch to theNEBULA_*wrapper types; subscription callbacks takeNEBULA_MESSAGE_CONST_SHARED_PTR(service callbacks keep the rclcpp-style shared_ptr signature, handled by the wrapper's convenience overload); publishes useALLOCATE_OUTPUT_MESSAGE_UNIQUE; and the CMakeagnocast_components_register_nodeexecutor becomesAgnocastOnlyCallbackIsolatedExecutor. UnderENABLE_AGNOCAST=0it falls back to the rclcpp backend unchanged.Review Procedure
Built with
ENABLE_AGNOCAST=0and=1. Ran logging_simulator + rosbag replay and confirmedobjects_raw/scan_rawpublish at ~10 Hz in both builds (agnocast build observed viaros2 topic hz_agnocast). Note: a Method-2agnocast_wrapper::Nodemust be launched as a standalone executable with the heaphook preloaded (not as a component in the agnocast CIE container); the corresponding launcher change lives outside nebula.Remarks
Recreated from the earlier draft attempt on this branch with the completed, build-verified migration.
This PR passes an
agnocast_wrapper::Node *toSyncToolingWorker, which only #469 makes it accept,while #469 drops the
rclcpp::Nodesupport that un-migrated drivers still rely on. No sequential mergeorder keeps
mainbuildable, so #469 + #458 + #470 must land together.