DOCS-3004: Fix undefined manifestsUrl variable on the native CRDs page for latest - #2912
Merged
Merged
Conversation
…e for latest The native v3 CRDs page for Calico Enterprise latest (3.23) used the undefined variable manifestsUrl in three manifest install commands, so they rendered literally as $[manifestsUrl]/manifests/... instead of a real download URL. Calico Enterprise never defines manifestsUrl; the correct variable is filesUrl. The three manifests resolve at the filesUrl location for v3.23.1. This is the same class of bug fixed in DOCS-2995 on the CRD migration page.
✅ Deploy Preview for calico-docs-preview-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview succeeded!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a variable substitution bug in the Calico Enterprise v3.23-2 versioned docs where the native v3 CRDs page referenced an undefined $[manifestsUrl] variable, causing the install commands to render as literal placeholder text instead of usable URLs.
Changes:
- Replaced
$[manifestsUrl]with$[filesUrl]in the “Manifest install” commands for:v3_projectcalico_org.yamltigera-operator.yamlcustom-resources.yaml
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native v3 CRDs page for Calico Enterprise latest (version 3.23) used the undefined variable manifestsUrl in three manifest install commands, so they rendered literally as $[manifestsUrl]/manifests/... instead of a real download URL. Calico Enterprise never defines manifestsUrl; the correct variable is filesUrl.
This is the same class of bug as DOCS-2995 on the CRD migration page, on a page that was missed. It was never caught by the link checker because an undefined variable renders as literal text, with no URL for the crawler to test.
The three target manifests (v3_projectcalico_org.yaml, tigera-operator.yaml, custom-resources.yaml) are published at the filesUrl location for v3.23.1, so the corrected links resolve.
Scope is limited to version-3.23-2/operations/native-v3-crds.mdx (three commands). Newer versions already use filesUrl.
Reviewers can check the changed page once the deploy preview builds:
https://tigera.atlassian.net/browse/DOCS-3004