Skip to content

Fix match rule keys for PathNamespace, Arg0Namespace and Arg0Path - #454

Merged
tmds merged 2 commits into
tmds:mainfrom
beerpsi-forks:fix/dbus-match-rule-names
Sep 2, 2026
Merged

tmds merged 2 commits into
tmds:mainfrom
beerpsi-forks:fix/dbus-match-rule-names

Conversation

@beer-psi

@beer-psi beer-psi commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

In accordance with the match rules table of the D-Bus specification: https://dbus.freedesktop.org/doc/dbus-specification.html#id-1.13.4.9.6.3

@tmds

tmds commented Sep 2, 2026

Copy link
Copy Markdown
Owner

Thanks!

Can you include a simple test that sets all properties on MatchRule and assert ToString to verify the rule uses the proper names?

@beer-psi

beer-psi commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Added a test. Note that this technically is an invalid rule string, since path and path_namespace are mutually exclusive per the specs:

Using both path and path_namespace in the same match rule is not allowed.

But I'm not sure if it's the library's place to enforce this rule or just let D-Bus returns the "Invalid match rule" error.

@tmds

tmds commented Sep 2, 2026

Copy link
Copy Markdown
Owner

Test looks good. I'll be including this change in a patch release in the coming week and post a message here when it is on nuget.org.

@tmds
tmds merged commit d096600 into tmds:main Sep 2, 2026
@tmds

tmds commented Sep 4, 2026

Copy link
Copy Markdown
Owner

The fix is in the 0.95.1 version which was just uploaded to nuget.org.

This was referenced Sep 4, 2026
JadeArkadian added a commit to JadeArkadian/FFXIV-Spanish-Patcher that referenced this pull request Sep 9, 2026
Updated [Avalonia](https://github.com/AvaloniaUI/Avalonia/) from 12.1.1
to 12.1.2.

<details>
<summary>Release notes</summary>

_Sourced from [Avalonia's
releases](https://github.com/AvaloniaUI/Avalonia//releases)._

No release notes found for this version range.

Commits viewable in [compare
view](https://github.com/AvaloniaUI/Avalonia//commits).
</details>

Updated [Avalonia.Desktop](https://github.com/AvaloniaUI/Avalonia/) from
12.1.1 to 12.1.2.

<details>
<summary>Release notes</summary>

_Sourced from [Avalonia.Desktop's
releases](https://github.com/AvaloniaUI/Avalonia//releases)._

No release notes found for this version range.

Commits viewable in [compare
view](https://github.com/AvaloniaUI/Avalonia//commits).
</details>

Updated [Avalonia.Fonts.Inter](https://github.com/AvaloniaUI/Avalonia/)
from 12.1.1 to 12.1.2.

<details>
<summary>Release notes</summary>

_Sourced from [Avalonia.Fonts.Inter's
releases](https://github.com/AvaloniaUI/Avalonia//releases)._

No release notes found for this version range.

Commits viewable in [compare
view](https://github.com/AvaloniaUI/Avalonia//commits).
</details>

Updated
[Avalonia.Headless.XUnit](https://github.com/AvaloniaUI/Avalonia/) from
12.1.1 to 12.1.2.

<details>
<summary>Release notes</summary>

_Sourced from [Avalonia.Headless.XUnit's
releases](https://github.com/AvaloniaUI/Avalonia//releases)._

No release notes found for this version range.

Commits viewable in [compare
view](https://github.com/AvaloniaUI/Avalonia//commits).
</details>

Updated
[Avalonia.Themes.Fluent](https://github.com/AvaloniaUI/Avalonia/) from
12.1.1 to 12.1.2.

<details>
<summary>Release notes</summary>

_Sourced from [Avalonia.Themes.Fluent's
releases](https://github.com/AvaloniaUI/Avalonia//releases)._

No release notes found for this version range.

Commits viewable in [compare
view](https://github.com/AvaloniaUI/Avalonia//commits).
</details>

Updated [Tmds.DBus.Protocol](https://github.com/tmds/Tmds.DBus) from
0.95.0 to 0.95.1.

<details>
<summary>Release notes</summary>

_Sourced from [Tmds.DBus.Protocol's
releases](https://github.com/tmds/Tmds.DBus/releases)._

## 0.95.1

Tmds.DBus.Protocol:
- MatchRule: fix key names for PathNamespace, Arg0Namespace and
Arg0Path. (tmds/Tmds.DBus#454)

Commits viewable in [compare
view](tmds/Tmds.DBus@rel/0.95.0...rel/0.95.1).
</details>

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions


</details>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jade Arkadian <9055641+JadeArkadian@users.noreply.github.com>
Co-authored-by: Jade Arkadian <jadearkadian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants