feat: medianBigint: bigint support for median() - #1925
Open
hazrid93 wants to merge 1 commit into
Open
Conversation
Closes toss#1588. Add medianBigint(nums: bigint[]): bigint: the middle value for odd length arrays; for even length, the truncated average `(a + b) / 2n` (bigint has no fractional type). Sorts using bigint comparison. Throws RangeError for an empty array (a bigint cannot represent NaN).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Antoliny0919
left a comment
Antoliny0919
left a comment
Contributor
There was a problem hiding this comment.
I suspect these PRs were generated by AI. They add features, but none of them include documentation or tests. Also, many of the issues are already assigned to other contributors.
I'm not sure how the maintainers feel about AI generated PRs, but submitting PRs indiscriminately like this doesn't seem like a good approach.
I think it would be a good idea to read the contribution guidelines again.
++ If AI was used during the development process, it would also be a good idea to clearly mention that in the PR description or include it in the commit messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1588.
Add medianBigint(nums: bigint[]): bigint: the middle value for odd length arrays; for even length, the truncated average
(a + b) / 2n(bigint has no fractional type). Sorts using bigint comparison. Throws RangeError for an empty array (a bigint cannot represent NaN).