fix/compat array fill iteratee guard - #1952
Open
kojesung wants to merge 5 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…x/compat-array-fill-iteratee-guard
…mpat-array-fill-iteratee-guard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[[1, 2], [3, 4]]. However, this wasn't because an isIterateeCall guard existed; it succeeded only by coincidence, because the outer array passed in by.mapturned intoNaNafter going throughMath.floor(), and was then coincidentally reset to 0 by theif (!start) start = 0handling in fill.ts. A test case was added for an exceptional situation where this coincidence does not hold (when the outer array has a single element).(array.map(fill)), lodash resets start/end to their default values via the isIterateeCall guard, but es-toolkit/compat's fill lacked this guard, causing it to behave differently from lodash in certain cases. Specifically, when the outer array has a single element([[5]].map(fill)), Number([[5]])coincidentally converts to 5, and start=5 ends up exceeding the array's length (1), so nothing gets filled — a bug. To prevent this case, the fix reuses the same isIterateeCall helper already used inevery/slice/...