Skip to content

[Bug] uv sizes can't be float #386

Description

@Trard

I have some models that have uv with size like 8.5. it gives me an error like

[16:25:14 WARN]: [BetterModel] Unable to load this model: sand_kill_effect
[16:25:14 WARN]: [BetterModel] Reason: Unable to parse this json asset: plugins/BetterModel/models/kill_effects/sand_kill_effect.bbmodel
[16:25:14 WARN]: [BetterModel] Stack trace:
[16:25:14 WARN]: [BetterModel] java.lang.RuntimeException: Unable to parse this json asset: plugins/BetterModel/models/kill_effects/sand_kill_effect.bbmodel
        at bettermodel-3.1.0-paper.jar//kr.toxicity.model.api.data.ModelAsset.toResult(ModelAsset.java:137)
        at bettermodel-3.1.0-paper.jar//kr.toxicity.model.util.GsonsKt.toTexturedModel(Gsons.kt:18)
        at bettermodel-3.1.0-paper.jar//kr.toxicity.model.manager.ModelManagerImpl.importModels$lambda$4(ModelManagerImpl.kt:60)
        at bettermodel-3.1.0-paper.jar//kr.toxicity.model.util.ParallelIOThreadPool.forEachParallel$lambda$1(Collections.kt:117)
        at bettermodel-3.1.0-paper.jar//kr.toxicity.model.util.ParallelIOThreadPool.forEachParallel$lambda$2$0(Collections.kt:99)
        at java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1825)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1090)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:614)
        at java.base/java.lang.Thread.run(Thread.java:1474)
Caused by: com.google.gson.JsonSyntaxException: java.lang.NumberFormatException: Expected an int but was 8.5 at line 1 column 121497 path $.textures[1].uv_height
        at com.google.gson.internal.bind.TypeAdapters$7.read(TypeAdapters.java:267)
        at com.google.gson.internal.bind.TypeAdapters$7.read(TypeAdapters.java:257)
        at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$2.readIntoArray(ReflectiveTypeAdapterFactory.java:257)
        at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$RecordAdapter.readField(ReflectiveTypeAdapterFactory.java:639)
        at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$RecordAdapter.readField(ReflectiveTypeAdapterFactory.java:568)
        at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:517)
        at com.google.gson.internal.bind.TypeAdapterRuntimeTypeWrapper.read(TypeAdapterRuntimeTypeWrapper.java:40)
        at com.google.gson.internal.bind.CollectionTypeAdapterFactory$Adapter.read(CollectionTypeAdapterFactory.java:84)
        at com.google.gson.internal.bind.CollectionTypeAdapterFactory$Adapter.read(CollectionTypeAdapterFactory.java:64)
        at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$2.readIntoArray(ReflectiveTypeAdapterFactory.java:257)
        at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$RecordAdapter.readField(ReflectiveTypeAdapterFactory.java:639)
        at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$RecordAdapter.readField(ReflectiveTypeAdapterFactory.java:568)
        at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:517)
        at com.google.gson.Gson.fromJson(Gson.java:1358)
        at com.google.gson.Gson.fromJson(Gson.java:1259)
        at com.google.gson.Gson.fromJson(Gson.java:1197)
        at bettermodel-3.1.0-paper.jar//kr.toxicity.model.api.data.ModelAsset.toResult(ModelAsset.java:131)
        ... 8 more
Caused by: java.lang.NumberFormatException: Expected an int but was 8.5 at line 1 column 121497 path $.textures[1].uv_height
        at com.google.gson.stream.JsonReader.nextInt(JsonReader.java:1353)
        at com.google.gson.internal.bind.TypeAdapters$7.read(TypeAdapters.java:265)
        ... 24 more

I guess it is caused by

@SerializedName("uv_width") int uvWidth,
@SerializedName("uv_height") int uvHeight

Can it be fixed

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions