Repository navigation
Release v2.5.6 - #268
Merged
Merged
Release v2.5.6#268
Conversation
Back-merge v2.5.5 from main into develop
…ilder) Re-derives the MEC migration (supersedes the stale #240 / tig/mec-port) onto current develop. Engine (src/Terminal.Gui.Editor): - Add Configuration/EditorSettings.cs (POCO + static Defaults facade), EditorKeyBindingDefaults.cs (default binding table), and EditorConfiguration.cs (Apply(IConfiguration) reading the "Editor" section + a legacy section). - Editor.Commands.cs: drop [ConfigurationProperty(Scope=typeof(SettingsScope))]; DefaultKeyBindings now delegates to EditorSettings.Defaults. - Reference Microsoft.Extensions.Configuration.Abstractions. ted: - Add TerminalGuiConfigurationBootstrap (TuiConfigurationBuilder -> ApplyToStaticFacades + EditorConfiguration.Apply + EditorSettings.Apply). - Migrate EditorSettings to a POCO + MEC bind; Save() writes the MEC-native "EditorSettings": {...} shape and migrates away from legacy dotted / AppSettings keys. Legacy CM attributes kept under #pragma CS0618 as a transition shim. - Program.cs: replace ConfigurationManager.Enable with the bootstrap. Tests: port keybinding-config + ted-persistence suites to the MEC path. Validated against Terminal.Gui release/v2.4.14-beta.1 (2.5.0-beta.1, contains #5411): build + Tests (571) + IntegrationTests (353) + ConfigTests (1) all green. Gating: the engine package builds against the current pinned TG, but ted needs TuiConfigurationBuilder (#5411), not yet in a published TG package - so hosted CI stays red until TG publishes a #5411 build and Editor's TerminalGuiVersion pin advances to it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2.4.15 is the first published stable TG with the MEC API this branch targets. Builds + Tests (571) + IntegrationTests (353) + ConfigTests (1) all green against the published package. Unblocks this PR's CI and fixes develop's red TG-bump canary once merged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- TedConfigurationManagerTests.cs: move #pragma warning disable CS0618 above the using block (ReSharper whole-solution cleanup canonical order) — the local Stop-hook only cleans changed files, so this committed-file drift slipped past it; CI's whole-solution gate caught it. - Program.cs: correct the bootstrap comment — there is no ConfigurationManager fallback; the MEC path requires Terminal.Gui >= 2.4.15 (addresses Codex review). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Port Editor and ted settings to MEC (re-derived; supersedes #240)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v2.5.6
Version:
2.5.6NuGet Package:
Terminal.Gui.Editor 2.5.6What happens when this PR is merged
v2.5.6Terminal.Gui.Editor 2.5.6to NuGet.orgmain->developis openedChecklist
2.5.6