Skip to content

Fixes regression where composition is not enabled by default. #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
taylorhadden wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixes regression where composition is not enabled by default. #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions src/modules/input.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,16 @@ export function input(editor: Editor) {
}
}

function setCompositionEnabled(enabled = true) {
if (enabled) {
editor.root.addEventListener('compositionstart', onCompositionStart);
editor.root.addEventListener('compositionend', onCompositionEnd);
} else {
editor.root.removeEventListener('compositionstart', onCompositionStart);
editor.root.removeEventListener('compositionend', onCompositionEnd);
}
}

// Browsers have had issues in the past with mutation observers firing consistently, so use the observer with the input
// event as fallback
function onInput() {
Expand Down Expand Up @@ -175,19 +185,12 @@ export function input(editor: Editor) {
}

return {
allowComposition(value = true) {
if (value) {
editor.root.addEventListener('compositionstart', onCompositionStart);
editor.root.addEventListener('compositionend', onCompositionEnd);
} else {
editor.root.removeEventListener('compositionstart', onCompositionStart);
editor.root.removeEventListener('compositionend', onCompositionEnd);
}
},
allowComposition: setCompositionEnabled,
init() {
editor.root.addEventListener('input', onInput);
editor.on('rendering', onRendering);
editor.on('render', onRender);
setCompositionEnabled(true)
if (isAndroid) {
editor.root.addEventListener('beforeinput', onBeforeInput); // needed for Gboard fix
}
Expand Down