fix: replace steno with internal atomic writer to fix Windows ENOENT race condition - #619
Open
ianshshakya wants to merge 1 commit into
Open
fix: replace steno with internal atomic writer to fix Windows ENOENT race condition#619ianshshakya wants to merge 1 commit into
ianshshakya wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #610
What does this PR do?
This PR drops the
stenodependency and inlines the asynchronous atomic writer directly intoTextFile.ts, updating it to use unique temporary filenames instead of a static one.Why is this necessary?
Currently, when
lowdbis used in a multi-process environment (most notably, parallel Jest tests), a severe race condition occurs on Windows resulting inENOENTcrashes.Because
stenoand the oldTextFileSyncstatically generated temporary filenames (e.g..<filename>.tmp), parallel worker processes end up overwriting each other's.tmpfiles. If Worker A successfully callsrename()before Worker B is finished, Worker B's subsequentrename()will crash with:ENOENT: no such file or directory, rename '.test-db.json.tmp' -> 'test-db.json'.The Fix
By natively implementing the atomic writer and appending a random 8-character hex string to the temporary filenames (e.g.
.<filename>.<randomStr>.tmp), we guarantee that concurrent parallel processes do not step on each other's toes. The final rename remains atomic, and theENOENTcrash is completely eliminated.