Repository navigation
Update uap-core - #105
Open
tincho4t wants to merge 1 commit into
Open
Update uap-core#105tincho4t wants to merge 1 commit into
tincho4t wants to merge 1 commit into
Conversation
Regenerate the embedded regex definitions via build.sh, moving the uap-core submodule from c941f1d (2024-09-27) to e3c5e63 (2026-08-11). Includes the OnePlus device detection fix from uap-core#668: user agents with an empty build token (trailing '; )') were falling through to Generic Smartphone. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
apologies for taking so long to get around to this, been a busy past few weeks... this looks fine to me but apparently I can't trigger CI on it anymore because I waited too long to take a look... 🤦 guess I'm going to have to add an empty commit before I can do that |
Contributor
|
... which I probably can't do as the branch for this PR comes from your repo. can you add an empty commit so I can trigger the tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerates the embedded regex definitions with
build.sh, moving theuap-coresubmodule fromc941f1d(2024-09-27) toe3c5e63(2026-08-11) — 99 upstream commits.Motivation: this picks up the OnePlus device detection fix from ua-parser/uap-core#668. User agents with an empty build token (trailing
; )), e.g.were falling through to
Generic Smartphoneinstead of resolving toOnePlus. The regex data in this repo predates that fix, so Go consumers don't get it yet.The sync also brings in roughly two years of other
uap-coreadditions (new browser and device tokens — Microsoft Teams embedded browser, Ladybird, Steam embedded browsers, QtWebEngine, and many more).Verification:
go test ./...inuaparserpasses.OnePlus ONEPLUS A7010, brandOnePlus, modelONEPLUS A7010;MODEL Build/...and cleanMODEL)forms are unchanged.🤖 Generated with Claude Code