feat(stovepipe): add queueconfig Store with default implementation#334
Merged
Conversation
1a66cd1 to
ee5ac0c
Compare
4d1f951 to
c814927
Compare
ee5ac0c to
c1ee23a
Compare
c814927 to
acdd570
Compare
c1ee23a to
7003035
Compare
acdd570 to
98cef3f
Compare
behinddwalls
approved these changes
Jul 13, 2026
behinddwalls
left a comment
Collaborator
There was a problem hiding this comment.
Clean extension slice — the Store interface mirrors the SubmitQueue queueconfig precedent exactly, config stores are the sanctioned exception to the extension input contract, no factory impls or routing in the extension package, and the README follows the prose-only rule. Two small inline notes, nothing blocking.
7003035 to
2b2eb79
Compare
Collaborator
|
This PR could not be automatically rebased after its base PR was merged. The rebase hit conflicts that need manual resolution. To fix manually: git fetch origin
git checkout mnoah1/stovepipe-process-queueconfig
git rebase --onto origin/main 2b2eb79ca6029db0ce819d1825d2b6dc37edf62f mnoah1/stovepipe-process-queueconfig
# resolve conflicts, then:
git push --force-with-leaseThen update this PR's base branch: gh pr edit 334 --base main |
Introduce queueconfig.Store and wire process to resolve per-queue max_concurrent at gate-check time. The default store returns global wiring constants; admit lands in a follow-up PR.
Align the package doc with the defaultconfig name and note that config Get failures need an explicit retryability decision once a real store lands.
98cef3f to
0c435d1
Compare
auto-merge was automatically disabled
July 13, 2026 21:00
Pull request was converted to draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Introduce queueconfig.Store and wire process to resolve per-queue max_concurrent for use when checking if we are ready to admit another build.
Why?
MVP logic to enqueue builds has two constants that will need to become configurable per queue in the future:
Test Plan