Skip to content

feat(stovepipe): add queueconfig Store with default implementation#334

Merged
mnoah1 merged 2 commits into
mainfrom
mnoah1/stovepipe-process-queueconfig
Jul 13, 2026
Merged

feat(stovepipe): add queueconfig Store with default implementation#334
mnoah1 merged 2 commits into
mainfrom
mnoah1/stovepipe-process-queueconfig

Conversation

@mnoah1

@mnoah1 mnoah1 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

What?

Introduce queueconfig.Store and wire process to resolve per-queue max_concurrent for use when checking if we are ready to admit another build.

Why?

MVP logic to enqueue builds has two constants that will need to become configurable per queue in the future:

  1. concurrent builds per queue (currently defaulting to 1)
  2. delay when we're not ready to build the latest head and need to re-enqueue it as a future process task to re-check

Test Plan

  • Unit tests below

@mnoah1 mnoah1 marked this pull request as ready for review July 10, 2026 16:25
@mnoah1 mnoah1 requested review from a team, behinddwalls and sbalabanov as code owners July 10, 2026 16:25
@mnoah1 mnoah1 force-pushed the mnoah1/stovepipe-process-coalesce branch from 1a66cd1 to ee5ac0c Compare July 10, 2026 18:21
@mnoah1 mnoah1 force-pushed the mnoah1/stovepipe-process-queueconfig branch from 4d1f951 to c814927 Compare July 10, 2026 18:22
@mnoah1 mnoah1 force-pushed the mnoah1/stovepipe-process-coalesce branch from ee5ac0c to c1ee23a Compare July 10, 2026 18:51
@mnoah1 mnoah1 force-pushed the mnoah1/stovepipe-process-queueconfig branch from c814927 to acdd570 Compare July 10, 2026 18:52
@behinddwalls behinddwalls force-pushed the mnoah1/stovepipe-process-coalesce branch from c1ee23a to 7003035 Compare July 10, 2026 20:07
@behinddwalls behinddwalls force-pushed the mnoah1/stovepipe-process-queueconfig branch from acdd570 to 98cef3f Compare July 10, 2026 20:07

@behinddwalls behinddwalls left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean extension slice — the Store interface mirrors the SubmitQueue queueconfig precedent exactly, config stores are the sanctioned exception to the extension input contract, no factory impls or routing in the extension package, and the README follows the prose-only rule. Two small inline notes, nothing blocking.

Comment thread stovepipe/extension/queueconfig/default/default.go Outdated
Comment thread stovepipe/controller/process/process.go
@mnoah1 mnoah1 force-pushed the mnoah1/stovepipe-process-coalesce branch from 7003035 to 2b2eb79 Compare July 13, 2026 19:46
@behinddwalls

Copy link
Copy Markdown
Collaborator

⚠️ Automatic stack rebase failed

This PR could not be automatically rebased after its base PR was merged. The rebase hit conflicts that need manual resolution.

To fix manually:

git fetch origin
git checkout mnoah1/stovepipe-process-queueconfig
git rebase --onto origin/main 2b2eb79ca6029db0ce819d1825d2b6dc37edf62f mnoah1/stovepipe-process-queueconfig
# resolve conflicts, then:
git push --force-with-lease

Then update this PR's base branch:

gh pr edit 334 --base main

mnoah1 added 2 commits July 13, 2026 20:28
Introduce queueconfig.Store and wire process to resolve per-queue
max_concurrent at gate-check time. The default store returns global wiring
constants; admit lands in a follow-up PR.
Align the package doc with the defaultconfig name and note that config
Get failures need an explicit retryability decision once a real store lands.
@mnoah1 mnoah1 force-pushed the mnoah1/stovepipe-process-queueconfig branch from 98cef3f to 0c435d1 Compare July 13, 2026 20:31
@mnoah1 mnoah1 changed the base branch from mnoah1/stovepipe-process-coalesce to main July 13, 2026 20:32
@mnoah1 mnoah1 enabled auto-merge July 13, 2026 20:32
@mnoah1 mnoah1 marked this pull request as draft July 13, 2026 21:00
auto-merge was automatically disabled July 13, 2026 21:00

Pull request was converted to draft

@mnoah1 mnoah1 marked this pull request as ready for review July 13, 2026 21:00
@mnoah1 mnoah1 enabled auto-merge July 13, 2026 21:01
@mnoah1 mnoah1 added this pull request to the merge queue Jul 13, 2026
Merged via the queue into main with commit 20139da Jul 13, 2026
35 of 39 checks passed
@behinddwalls behinddwalls deleted the mnoah1/stovepipe-process-queueconfig branch July 14, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants