feat: implement getversionsasync in mock - #1140
Merged
Merged
Conversation
msrouchou
reviewed
Sep 10, 2026
Comment on lines
+490
to
+492
| // INVESTIGATION SCAFFOLDING: `operationName` (optional, so existing call sites are unaffected) identifies | ||
| // which of the ~30 call sites is retrying, since the shared test output otherwise interleaves indistinguishable | ||
| // "RetryUntilAsync {n}..." lines from concurrent/sequential polls (e.g. branch-readiness vs. mergeable-status). |
Member
There was a problem hiding this comment.
comment seems relevant to a coding session and not interesting for the end user ? wither we rework the comment or remove it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement GetVersionsAsync in MergeRequestClient to be able to add comments and threads into reviews.
Add Comment, Discussion, Versions mock tests
Simplify CreateMergeRequestAsync: