fix: the delete_viewport endpoint calls check_viewpo... in viewports.py - #4
Open
anupamme wants to merge 1 commit into
Open
Conversation
Automated security fix generated by OrbisAI Security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix high severity security issue in
api/views/viewports.py.Vulnerability
V-002api/views/viewports.py:280Description: The delete_viewport endpoint calls check_viewport_owner() which has a critical flaw: if a viewport does not have a _config.json file (legacy viewports), the function returns (True, None), allowing ANY user to delete it. This creates an authorization bypass for viewports created before the config file system was implemented.
Evidence
Exploitation scenario: An attacker discovers the name of a legacy viewport (one without a _config.json file) by enumerating viewport names or through information disclosure.
Scanner confirmation: multi_agent_ai rule
V-002flagged this pattern.Production code: This file is in the production codebase, not test-only code.
Threat Model Context
This view handler appears to be publicly accessible. This is a web service - vulnerabilities in request handlers are directly exploitable by remote attackers.
Changes
api/helpers.pyBehavior Preservation
The change is scoped to 1 file on the vulnerable path; it only tightens handling of untrusted input and leaves valid inputs unaffected.
Automated security fix by OrbisAI Security