Conversation
2 tasks
clmould
force-pushed
the
4174-only-read-indats-using-the-indat-class
branch
from
August 13, 2026 16:26
bc34539 to
eda15dc
Compare
2 tasks
clmould
force-pushed
the
4174-only-read-indats-using-the-indat-class
branch
3 times, most recently
from
August 27, 2026 13:14
72a627d to
e8a494b
Compare
clmould
force-pushed
the
4174-only-read-indats-using-the-indat-class
branch
6 times, most recently
from
September 2, 2026 12:47
9816a42 to
d4d920c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4523 +/- ##
==========================================
+ Coverage 49.88% 50.04% +0.16%
==========================================
Files 151 151
Lines 29871 29935 +64
==========================================
+ Hits 14901 14981 +80
+ Misses 14970 14954 -16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
clmould
force-pushed
the
4174-only-read-indats-using-the-indat-class
branch
from
September 11, 2026 18:03
1def96a to
756ea41
Compare
clmould
force-pushed
the
4174-only-read-indats-using-the-indat-class
branch
from
September 11, 2026 18:08
756ea41 to
698f4a5
Compare
…undl(index) = value , and use f_nd_impurity_electrons instead of bound in a test for input array remove outdated comment and add TODO docstring to fill in after review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
validate_inputto theInDatclass and rename tocheck_obsolete_variablesparse_input_fileno longer re-reads the file line by line and instead uses the data read in byInDatChecklist
I confirm that I have completed the following checks: