Skip to content

4174 only read indats using the indat class - #4523

Draft
clmould wants to merge 8 commits into
mainfrom
4174-only-read-indats-using-the-indat-class
Draft

clmould wants to merge 8 commits into
mainfrom
4174-only-read-indats-using-the-indat-class

Conversation

@clmould

@clmould clmould commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Description

  • Moves validate_input to the InDat class and rename to check_obsolete_variables
  • parse_input_file no longer re-reads the file line by line and instead uses the data read in by InDat
  • Fix PLR1702 errors in these files

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould linked an issue Aug 13, 2026 that may be closed by this pull request
2 tasks
@clmould
clmould force-pushed the 4174-only-read-indats-using-the-indat-class branch from bc34539 to eda15dc Compare August 13, 2026 16:26
@clmould
clmould force-pushed the 4174-only-read-indats-using-the-indat-class branch 3 times, most recently from 72a627d to e8a494b Compare August 27, 2026 13:14
@clmould
clmould force-pushed the 4174-only-read-indats-using-the-indat-class branch 6 times, most recently from 9816a42 to d4d920c Compare September 2, 2026 12:47
@codecov-commenter

codecov-commenter commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 79.05405% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.04%. Comparing base (620d1e9) to head (4149387).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
process/core/io/in_dat/base.py 59.72% 29 Missing ⚠️
process/core/input.py 97.05% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4523      +/-   ##
==========================================
+ Coverage   49.88%   50.04%   +0.16%     
==========================================
  Files         151      151              
  Lines       29871    29935      +64     
==========================================
+ Hits        14901    14981      +80     
+ Misses      14970    14954      -16     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clmould
clmould force-pushed the 4174-only-read-indats-using-the-indat-class branch from 1def96a to 756ea41 Compare September 11, 2026 18:03
@clmould
clmould force-pushed the 4174-only-read-indats-using-the-indat-class branch from 756ea41 to 698f4a5 Compare September 11, 2026 18:08
…undl(index) = value , and use f_nd_impurity_electrons instead of bound in a test for input array

remove outdated comment and add TODO docstring to fill in after review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Only read IN.DATs using the InDat class

2 participants